Repository navigation
fix(db): Align db instrumentations to require a parent span - #25879
Draft
nicohrubec wants to merge 7 commits into
Draft
nicohrubec wants to merge 7 commits into
nicohrubec wants to merge 7 commits into
Conversation
Co-Authored-By: GPT-6 <codex@openai.com>
nicohrubec
changed the title
This was referenced Oct 29, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 368dc83. Configure here.
This was referenced Oct 29, 2026
Contributor
size-limit report 📦Compared: 3981477 (PR test merge using develop at 53daa00) Against: 53daa00 (develop) · base run #64191 ✅ Baseline matches: this diff contains only this PR's changes.
|
andreiborza
approved these changes
Oct 29, 2026
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 56 successful. See the run.
Successful checks
|
mydea
reviewed
Oct 29, 2026
mydea
reviewed
Oct 29, 2026
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
nicohrubec
marked this pull request as ready for review
October 29, 2026 14:48
nicohrubec
requested review from
chargome,
isaacs and
mydea
and removed request for
a team
October 29, 2026 14:48
andreiborza
reviewed
Oct 29, 2026
| const { default: Redis } = await import('ioredis-5'); | ||
| const redisClient = new Redis({ host: '127.0.0.1', port: 6382, lazyConnect: true }); | ||
|
|
||
| await redisClient.connect(); |
Member
There was a problem hiding this comment.
This moved into startSpan so that the connect span gets recorded right?
This seems like an annoying downside... I'd assume most users don't have the connect call inside a span. 🤔
Member
Author
There was a problem hiding this comment.
yes that's the reason. why do you worry about the connect call specifically?
Member
Author
There was a problem hiding this comment.
if this is a special case we can exempt the connect span
Member
There was a problem hiding this comment.
I'd assume most users call connect on app startup and it will probably not have a parent span. I think we need to exempt here.
Member
Author
There was a problem hiding this comment.
yeah sounds reasonable I'll exempt all the connect spans then similar for mysql2 and postgresql
Co-Authored-By: GPT-6 <codex@openai.com>
andreiborza
approved these changes
Oct 29, 2026
nicohrubec
marked this pull request as draft
October 29, 2026 17:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Unparented DB queries and cache commands lack application context. Use core's
onlyIfParentto align all db instrumentations to only start spans if there is an active parent.How to review: This adds
onlyIfParent: trueto all db instrumentations, replacingrequiresParentSpanwhere necessary. Spans that are emitted at server startup (e.g. redis connect spans) where we can assume that in most cases no parent will be active are exempt from this rule.Closes #25793
Closes #25796
Closes #25798
Closes #25799
Closes #25801
Closes #25802
Closes #25803
Closes #25804
Closes #25805