Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lazerg
marked this pull request as ready for review
October 29, 2026 07:27
lazerg
requested review from
andreiborza and
isaacs
and removed request for
a team
October 29, 2026 07:27
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b1a3b32. Configure here.
…an test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
after some more internal discussion on the approach for this I'll close this down as superseded by #25879 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why: DynamoDB calls made outside any active span each became their own root span with no context. The aws-sdk integration now skips the span for DynamoDB when there is no active span. Other services keep their current behavior, since a root producer span can be valid for S3, SQS, SNS or Lambda.
How to review: The fix is the early return in
aws-sdk/index.ts. The new scenario runsPutItembefore, inside and after a parent span and checks that only the one inside creates a span, on both aws-sdk versions the suite covers.Closes #25801