Skip to content

fix(server-utils): Require a parent span for aws-sdk DynamoDB operations - #25858

Closed
lazerg wants to merge 2 commits into
getsentry:developfrom
lazerg:fix/aws-sdk-dynamodb-require-parent-span
Closed

lazerg wants to merge 2 commits into
getsentry:developfrom
lazerg:fix/aws-sdk-dynamodb-require-parent-span

Conversation

@lazerg

@lazerg lazerg commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Why: DynamoDB calls made outside any active span each became their own root span with no context. The aws-sdk integration now skips the span for DynamoDB when there is no active span. Other services keep their current behavior, since a root producer span can be valid for S3, SQS, SNS or Lambda.

How to review: The fix is the early return in aws-sdk/index.ts. The new scenario runs PutItem before, inside and after a parent span and checks that only the one inside creates a span, on both aws-sdk versions the suite covers.

Closes #25801

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the external PR from an external contributor label Oct 29, 2026
@lazerg
lazerg marked this pull request as ready for review October 29, 2026 07:27
@lazerg
lazerg requested a review from a team as a code owner October 29, 2026 07:27
@lazerg
lazerg requested review from andreiborza and isaacs and removed request for a team October 29, 2026 07:27

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b1a3b32. Configure here.

Comment thread dev-packages/node-integration-tests/suites/aws-serverless/aws-integration/test.ts Outdated
…an test

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nicohrubec

Copy link
Copy Markdown
Member

after some more internal discussion on the approach for this I'll close this down as superseded by #25879

@nicohrubec nicohrubec closed this Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from an external contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only create aws-sdk DynamoDB db spans when there is a parent span

2 participants