Repository navigation
fix(server-utils): Require a parent span for Nitro storage - #25861
Closed
nicohrubec wants to merge 1 commit into
Closed
nicohrubec wants to merge 1 commit into
nicohrubec wants to merge 1 commit into
Conversation
Co-Authored-By: GPT-6 <codex@openai.com>
nicohrubec
marked this pull request as ready for review
October 29, 2026 07:40
nicohrubec
requested review from
andreiborza and
mydea
and removed request for
a team
October 29, 2026 07:40
Contributor
size-limit report 📦Compared: 907adc5 (PR test merge using develop at b722d3c) Against: b722d3c (develop) · base run #64034 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 61 successful. See the run.
Successful checks
|
nicohrubec
marked this pull request as draft
October 29, 2026 12:24
Member
Author
|
superseded by #25879 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Skip automatic Nitro storage spans outside an instrumented operation because they lack the application context needed to identify their origin, aligning with the parent requirement for DB spans.
How to review: The fix adds
requiresParentSpan: trueto the shared storage binding. The rest of this PR is regression coverage.Closes #25803