Repository navigation
Conversation
…span Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lazerg
marked this pull request as ready for review
October 29, 2026 07:05
lazerg
requested review from
andreiborza and
mydea
and removed request for
a team
October 29, 2026 07:05
Lms24
self-requested a review
October 29, 2026 09:35
…ll paths Move the redis v2-v3 subscriber onto bindTracingChannelToSpan so every Redis path checks for a parent span the same way. The wrapped command callback still ends the span; deferSpanEnd keeps the helper from ending it on the sync return. Add no-parent tests for ioredis, node-redis v4/v5 (orchestrion), native batch commands, and a unit test for the legacy path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
I made some changes to this PR, where I'd appreciate a review from someone on the team with more DC experience:
|
Member
|
after some more internal discussion on the approach for this I'll close this down as superseded by #25879 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Redis commands and connects that run outside any active span (blocking
XREADloops, ioredis cluster slot refreshes, background jobs) each start their own trace and get sampled as root transactions with no context. The older ioredis instrumentation already required a parent, so this does the same for the nativenode-redis:*/ioredis:*channels, the node-redis v4/v5 orchestrion channels, and legacy redis v2/v3.How to review: The fix is
requiresParentSpan: trueon eachbindTracingChannelToSpancall, plus an early return in the legacy subscriber. The existing tests expected a standaloneredis-connectsegment, which is now gone.scenario-no-parent.mjschecks that only the command inside the parent span gets a span.Fixes #25793
Closes #25798