Repository navigation
ref(server-utils): Use onlyIfParent for DataLoader spans - #25882
Closed
nicohrubec wants to merge 1 commit into
Closed
nicohrubec wants to merge 1 commit into
nicohrubec wants to merge 1 commit into
Conversation
Co-Authored-By: GPT-6 <codex@openai.com>
Contributor
size-limit report 📦Compared: def9b5f (PR test merge using develop at 51248d4) Against: 51248d4 (develop) · base run #64139 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 2 not successful, 53 successful. See the run.
Successful checks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: DataLoader already sets
onlyIfParentin its shared span options, but its channel guards skip core'sno_parent_spanaccounting. Let core handle the parent requirement consistently.How to review: Only removes the redundant DataLoader guards. Split from #25879 to keep that PR focused on database instrumentations.