Repository navigation
fix(server-utils): Require a parent span for Prisma operations - #25863
Closed
nicohrubec wants to merge 3 commits into
Closed
nicohrubec wants to merge 3 commits into
nicohrubec wants to merge 3 commits into
Conversation
Co-Authored-By: GPT-6 <codex@openai.com>
Contributor
size-limit report 📦Compared: c78ca1f (PR test merge using develop at 61d2b26) Against: 61d2b26 (develop) · base run #64083 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 64 successful. See the run.
Successful checks
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 71a98da. Configure here.
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Member
Author
|
superseded by #25879 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Prisma creates root DB spans without the application context needed to identify their origin. Require a parent for client spans and v6/v7 engine batches, aligning with the v8 path and other DB integrations.
How to review: Callbacks still execute without a parent; v5 delayed replay keeps resolving recorded parents. Existing Prisma v5/v6 integration suites cover queries with and without an active parent. Focused helper tests cover unparented engine dispatch and parented engine/DB relationships.
Closes #25802