Repository navigation
Conversation
lazerg
requested review from
andreiborza and
isaacs
and removed request for
a team
October 29, 2026 06:56
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lazerg
force-pushed
the
feat/mongoose-require-parent-span
branch
from
October 29, 2026 07:28
34219b3 to
95a80a3
Compare
Member
|
after some more internal discussion on the approach for this I'll close this down as superseded by #25879 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Skip automatic Mongoose DB spans when there is no parent span, since each one ends up as its own root span with no context, same as the other DB integrations.
How to review: The native channel subscriber (mongoose >= 9.7) passes
requiresParentSpan: true. The orchestrion path (mongoose < 9.7) creates no span when there is neither a build-time parent nor an active span, so a query built inside a span but awaited outside it still parents to that span. The rest is regression coverage for both paths.Closes #25799