Skip to content

refactor: EXPKITS-1569 connect inputs to concrete producers - #276

Merged
zmolnar merged 1 commit into
feature/EXPKITS-1535-adoption-verificationfrom
feature/EXPKITS-1569-explicit-input-connections
Nov 16, 2026
Merged

zmolnar merged 1 commit into
feature/EXPKITS-1535-adoption-verificationfrom
feature/EXPKITS-1569-explicit-input-connections

Conversation

@zmolnar

@zmolnar zmolnar commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Goal

EXPKITS-1569: Remove semantic content-type routing end to end. This layer sits above #271 in native stack #248; the keyword-comparison regression fix follows in #290.

Change

Before

Payload types and semantic contentType/role labels jointly selected dependencies, ROI inputs and presentation. Multiple producers with the same label could satisfy a consumer.

After

  • SDK payload types define compatibility; named consumer inputs connect to concrete producer identities. Local sourceOp references and external bindings are explicit.
  • Live input selection activates only the connected compatible producer. Missing, unconnected and ambiguous inputs have no semantic fallback. Python callbacks receive immutable connection snapshots.
  • Remove the shared SDK field and Model field, role matching and subtype-based tracker/overlay selection. Migrate native consumers, WebUI, Plumber, configurations and generated SDKs together.
  • Model and OpChain formats advance to 2.0.0. Pipeline formats remain major 1. SDK/product identity remains the coordinated, unreleased 1.0.0; intermediate snapshots must be rebuilt together.
  • Saved overlay v2 records migrate to v3, preserving explicit renderers, source identities and settings while dropping retired selector fields.
  • Preserve main's newer audio-window handling, OR runtime descriptors, ordered browser toggles and renamed property contracts while integrating explicit inputs. Migrate the OR example descriptors and select keyword console output by concrete producer identity.
  • The compatibility baseline is main's 0.1.3. These breaking changes belong to the coordinated, unreleased 1.0.0 transition; there is no old-packet adapter or stable package publication.

Testing

Post-rebase integration validation — 2026-11-16

Validated the assembled stack ending in #276 (aad8a7f218a2), rebased onto main
9e62fe21ccd2:

  • Debug build succeeded. The native suite exercised 110 targets: 108 passed and
    two intentional failure tests behaved as expected, including reruns of the
    three corrected descriptor-validation targets.
  • WebUI unit suites and 53 Plumber tests passed.
  • SDK snapshot and Web bundle drift checks, scoped formatting/licence checks,
    and documentation/diagram generation passed.
  • The optional OR adapter also compiled with
    NINJAFLAGS=-j2 ./scripts/build.sh debug true --extra-setup-args=-Dor_runtime=true.
    Its hardware-specific model/runtime execution was not exercised.
  • Signed commits, DCO trailers, linear stack ancestry and remote head/base
    relationships were verified.

This is assembled-stack local evidence. Individual PR CI is reported by each
PR's current-head Checks tab. The separate uncommitted bootstrap/download fixes
are outside this stack and were not part of these integration checks.

Historical acceptance — 2026-11-12, before the latest rebase

Earlier verification passed 102 native targets, 135 SDK-tool tests, 47 Plumber
tests and eight real-Chrome overlay regressions. Real ONNX CPU RetinaFace/gaze
execution covered all four resolution/backbone combinations, blank input and
live switching/reactivation; changed-line clang-tidy reported zero findings.
These historical results are distinct from the post-rebase checks above.
ExecuTorch/MLWL, physical-camera/GPU and live microphone qualification were not
performed as part of the latest rebase validation.

Reproduction commands

From the repository root inside the supported OPK development container, with
the pinned submodules initialized and the normal model/media setup available:

NINJAFLAGS=-j2 ./scripts/build.sh debug true
meson test -C development/build-active --print-errorlogs --num-processes 2
./scripts/perception-sdk.sh check
./scripts/opksink-web.sh test
./scripts/opksink-web.sh check
PYTHONPATH=tools/plumber:generated/open_perception_kit/python/src python3 -m unittest discover -s tools/plumber/tests

From the host checkout, run ./scripts/gen-doc.sh to generate and validate the
documentation and diagrams in build output.

Links

Part of the breaking, unreleased SDK/product 1.0.0 refactor. Producers and consumers
must use compatible regenerated snapshots. Stable release packaging/publication is separate.

@zmolnar
zmolnar requested review from a team as code owners November 12, 2026 12:30
@zmolnar
zmolnar added this pull request to stack #248 November 12, 2026 12:30
Comment thread development/web/src/models.js Resolved
Comment thread schemas/perception/metadata/common.fbs Resolved
@zmolnar
zmolnar force-pushed the feature/EXPKITS-1569-explicit-input-connections branch from 7b6340f to 7bae54f Compare November 13, 2026 11:29
Comment thread config/schemas/v2/model.schema.json Resolved
Comment thread docs/public/how-to/bring-your-model.md Resolved
Comment thread development/web/README.md Resolved
Szendvics
Szendvics previously approved these changes Nov 16, 2026
Task: EXPKITS-1569

Remove semantic content-type routing from the SDK, runtime and consumers.
Migrate Model and OpChain contracts to v2 and verify explicit live connections.

Signed-off-by: Zoltan Molnar <zoltan.molnar@arm.com>

@Szendvics Szendvics left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as is.

@zmolnar
zmolnar enabled stacked auto-merge (squash) November 16, 2026 14:03
@zmolnar
zmolnar merged commit c8a96c8 into main Nov 16, 2026
20 checks passed
@zmolnar
zmolnar deleted the feature/EXPKITS-1569-explicit-input-connections branch November 16, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants