Skip to content

fix: EXPKITS-1575 restore Plumber keyword comparison - #290

Merged
zmolnar merged 2 commits into
feature/EXPKITS-1569-explicit-input-connectionsfrom
bugfix/EXPKITS-1575-keyword-plumber-comparison
Nov 16, 2026
Merged

zmolnar merged 2 commits into
feature/EXPKITS-1569-explicit-input-connectionsfrom
bugfix/EXPKITS-1575-keyword-plumber-comparison

Conversation

@zmolnar

@zmolnar zmolnar commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Goal

EXPKITS-1575: Restore Plumber comparison for keyword detections after the SDK 1.0 refactor. This is a focused follow-up above #276 in native stack #248.

Change

Before

Main 9e62fe21 allowed parentless classifications and compared their top labels. The refactored comparator required a resolved spatial subject, so even an identical serialized keyword result failed with subject missing, ambiguous or invalid.

After

  • Recognize explicitly subjectless Categorical results as comparable within their producer-scoped payload group.
  • Preserve SDK 1.0 label-set/class identity and candidate validation, rather than reverting to display-text identity or guessing a parser/content type.
  • Require normal subject resolution and correspondence whenever either result declares a subject. Subjectless and subject-bound results cannot match.
  • Add a serialized-packet regression and document this comparison contract. The fix is limited to Plumber comparison, its tests and documentation; no schema change is required.

Testing

Local verification on 2026-11-16:

  • Confirmed the new regression failed before the fix and passed afterward.
  • All 54 Plumber tests passed. Coverage includes identical keywords, renamed display labels, different classes/vocabularies/producers, optional and invalid confidence, mixed subject presence, and zero/dangling/ambiguous declared subjects.
  • Scoped pre-commit checks and git diff --check passed; commit hooks passed.
  • Documentation generation and validation passed.

From the repository root inside the development container:

PYTHONPATH=tools/plumber:generated/open_perception_kit/python/src python3 -m unittest discover -s tools/plumber/tests
opk-ci --pre-commit-check --list-of-files tools/plumber/plumber/distance_classification.py tools/plumber/plumber/frame_results_compare.py tools/plumber/tests/test_frame_results_compare.py docs/arch/perception.md

Documentation was checked from the host with:

DOCS_IMAGE=opk-docs:local ./scripts/gen-doc.sh

Current-head CI results are in the PR Checks tab. Approval and required CI remain merge gates.

Links

Task: EXPKITS-1575

Compare subjectless categorical results within their producer scope.
Retain categorical identity and validation of every declared subject.
Add a serialized-packet regression and document the comparison contract.

Signed-off-by: Zoltan Molnar <zoltan.molnar@arm.com>
Szendvics
Szendvics previously approved these changes Nov 16, 2026

@Szendvics Szendvics left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as is.

@zmolnar
zmolnar enabled stacked auto-merge (squash) November 16, 2026 14:03
Task: EXPKITS-1575

Run the required title check for every PR target branch and align
the contribution guidance with stacked pull requests.

Signed-off-by: Zoltan Molnar <zoltan.molnar@arm.com>
@zmolnar
zmolnar merged commit 8a3ca70 into main Nov 16, 2026
18 checks passed
@zmolnar
zmolnar deleted the bugfix/EXPKITS-1575-keyword-plumber-comparison branch November 16, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants