Repository navigation
feat: EXPKITS-1533 publish structured performance measurements - #247
Conversation
|
All 18 checks now pass on d4c6cbf, including Clang-tidy, Valgrind, Meson, SDK tests, CodeQL and the x86_64/aarch64 quick-start browser smoke tests. The optional-access warnings were fixed without changing rendering behaviour; targeted local static analysis and pixel-equivalence tests also pass. |
d4c6cbf to
30c9172
Compare
30c9172 to
655753b
Compare
ea09046 to
cf2f23a
Compare
cf2f23a to
e876229
Compare
Szendvics
left a comment
There was a problem hiding this comment.
Nit: The execution-flow diagram source still says opkperformance appends PerformanceOverlayT. Please update it to PerformanceMeasurementsT and regenerate the diagram used by the architecture overview.
e876229 to
4f0c70f
Compare
|
Addressed the diagram review note in 4f0c70f: execution-flow.puml now names PerformanceMeasurementsT, and docs/public/static/img/execution-flow.png was regenerated using the repository PlantUML 1.2026.2 toolchain. The generated PNG metadata confirms the updated source. All three inline performance findings also have fix/evidence replies. |
Szendvics
left a comment
There was a problem hiding this comment.
Rechecked the fixes at 4f0c70f3 and found no remaining blocking issues. The performance payload change is accepted as breaking, so migration of old saved performance preferences is not required.
Task: EXPKITS-1533 Replace text transport with typed numeric measurements, explicit producer and scope identity, and independent mean/p95 availability. Preserve display labels without using them as smoothing keys. Includes EXPKITS-1542 audit corrections. Signed-off-by: Zoltan Molnar <zoltan.molnar@arm.com>
4f0c70f to
ef6ce17
Compare
Goal
EXPKITS-1533: Publish performance measurements with explicit identity and availability.
Change
Before
Formatted text acted as the protocol. Display labels mixed unrelated histories; p95-only rows and unnamed scopes could disappear.
After
Testing
Coverage and historical validation
Native, wire and browser regressions cover hierarchy/reordering, truncated names, distinct publishers, saved selections and unavailable duplicates. The 10/100 ms reproduction now displays 100 ms rather than 55 ms. The execution-flow PlantUML source now names
PerformanceMeasurementsT; PNGs are generated in documentation build output by./scripts/gen-doc.sh, rather than committed source assets. Shared fixture work also addresses EXPKITS-1560.Post-rebase evidence
The 2026-11-16 assembled-stack build, native/WebUI/Plumber tests, SDK/bundle checks
and documentation validation are recorded in the Testing section of #276
at
aad8a7f218a2. These results supplement the earlier coverage above; they are notstandalone local reruns at every lower PR head.
Reproduction commands
From the repository root inside the supported OPK development container, with
the pinned submodules initialized and the normal model/media setup available:
From the host checkout, run
./scripts/gen-doc.shto generate and validate thedocumentation and diagrams in build output.
Links
9e62fe21ccd2.ef6ce177d145.Part of the breaking, unreleased SDK/product 1.0.0 refactor. Producers and consumers
must use compatible regenerated snapshots. Stable release packaging/publication is separate.