Skip to content

feat: EXPKITS-1529 make gaze measurements and subjects explicit - #259

Merged
zmolnar merged 1 commit into
feature/EXPKITS-1528-classification-outcomesfrom
feature/EXPKITS-1529-gaze-measurements
Nov 16, 2026
Merged

zmolnar merged 1 commit into
feature/EXPKITS-1528-classification-outcomesfrom
feature/EXPKITS-1529-gaze-measurements

Conversation

@zmolnar

@zmolnar zmolnar commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Goal

EXPKITS-1529: Make gaze measurements, availability and subjects explicit.

Change

Before

Gaze used generic poses and implicit unit/sign/parent conventions. Failed calculations could become zero-angle measurements; consumers disagreed on eligible subjects, and comparison ignored angular wrap and associations.

After

  • Publish GazeMeasurements with optional degree-angle pairs, confidence and explicit subjects. (0,0) is a measurement; absent angles are unavailable.
  • Apply the documented unmirrored-image convention and reject non-finite logits without changing valid soft-argmax mappings.
  • Share unique box/track subject rules across consumers. Plumber checks producer-scoped correspondence and shortest angular differences, retaining the 1.8-degree tolerance.
  • Replace the old pose payload and migrate saved overlay preferences; do not decode old packets.

Testing

Coverage and historical validation

Parser, native/browser, comparison, live MobileGaze and bridge regressions cover invalid values, ambiguity, reordered observations and swapped angles. Fixes 1555, 1556, 1557, 1558 and 1561. The #272 ResNet gaze integration test now checks explicit subjects/angles; all four model/resolution combinations, blank input and live switching/reactivation pass on ONNX CPU. Persistent track-subject matching is completed in #269.

Post-rebase evidence

The 2026-11-16 assembled-stack build, native/WebUI/Plumber tests, SDK/bundle checks
and documentation validation are recorded in the Testing section of #276
at aad8a7f218a2. These results supplement the earlier coverage above; they are not
standalone local reruns at every lower PR head.

Reproduction commands

From the repository root inside the supported OPK development container, with
the pinned submodules initialized and the normal model/media setup available:

NINJAFLAGS=-j2 ./scripts/build.sh debug true
meson test -C development/build-active --print-errorlogs --num-processes 2
./scripts/perception-sdk.sh check
./scripts/opksink-web.sh test
./scripts/opksink-web.sh check
PYTHONPATH=tools/plumber:generated/open_perception_kit/python/src python3 -m unittest discover -s tools/plumber/tests

From the host checkout, run ./scripts/gen-doc.sh to generate and validate the
documentation and diagrams in build output.

Links

Part of the breaking, unreleased SDK/product 1.0.0 refactor. Producers and consumers
must use compatible regenerated snapshots. Stable release packaging/publication is separate.

@zmolnar
zmolnar requested review from a team as code owners November 6, 2026 12:48
@zmolnar
zmolnar added this pull request to stack #248 November 6, 2026 12:48
@zmolnar
zmolnar force-pushed the feature/EXPKITS-1529-gaze-measurements branch from cccca4c to 7b6f8a8 Compare November 6, 2026 18:23
@zmolnar
zmolnar force-pushed the feature/EXPKITS-1529-gaze-measurements branch 2 times, most recently from c7ae5bb to e5f7e45 Compare November 7, 2026 07:46
@zmolnar
zmolnar force-pushed the feature/EXPKITS-1529-gaze-measurements branch from e5f7e45 to 54168c3 Compare November 11, 2026 10:31
@zmolnar
zmolnar force-pushed the feature/EXPKITS-1529-gaze-measurements branch from 54168c3 to 0a4ec56 Compare November 11, 2026 11:07
@zmolnar
zmolnar force-pushed the feature/EXPKITS-1529-gaze-measurements branch from 0a4ec56 to 20e10aa Compare November 11, 2026 12:40
@zmolnar
zmolnar force-pushed the feature/EXPKITS-1529-gaze-measurements branch from 20e10aa to 05140d1 Compare November 11, 2026 15:56
@zmolnar
zmolnar force-pushed the feature/EXPKITS-1529-gaze-measurements branch from 05140d1 to 4597ff3 Compare November 12, 2026 07:08
Comment thread development/tests/gaze_pipeline_test.py Resolved
Comment thread development/tests/gaze_pipeline_test.py Resolved
@zmolnar
zmolnar force-pushed the feature/EXPKITS-1529-gaze-measurements branch from 4597ff3 to fd52cea Compare November 13, 2026 11:29
Szendvics
Szendvics previously approved these changes Nov 16, 2026
Task: EXPKITS-1529

Address EXPKITS-1555 through EXPKITS-1558 and EXPKITS-1561. Publish optional
degree-angle pairs and use the shared explicit subject-resolution contracts.
Compare wrapped angles for corresponding subjects, regenerate SDKs, and migrate
all consumers and browser smoke fixtures together.

Signed-off-by: Zoltan Molnar <zoltan.molnar@arm.com>
@zmolnar
zmolnar force-pushed the feature/EXPKITS-1529-gaze-measurements branch from fd52cea to 226ee9e Compare November 16, 2026 12:50

@Szendvics Szendvics left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as is.

@zmolnar
zmolnar enabled stacked auto-merge (squash) November 16, 2026 14:03
@zmolnar
zmolnar merged commit 03af95d into main Nov 16, 2026
19 checks passed
@zmolnar
zmolnar deleted the feature/EXPKITS-1529-gaze-measurements branch November 16, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants