Repository navigation
Conversation
zmolnar
force-pushed
the
feature/EXPKITS-1531-embedding-spaces
branch
from
November 11, 2026 10:31
5031196 to
692428f
Compare
zmolnar
force-pushed
the
feature/EXPKITS-1531-embedding-spaces
branch
from
November 11, 2026 11:08
692428f to
aeca55c
Compare
zmolnar
force-pushed
the
feature/EXPKITS-1531-embedding-spaces
branch
from
November 11, 2026 12:40
aeca55c to
eb224e2
Compare
zmolnar
force-pushed
the
feature/EXPKITS-1531-embedding-spaces
branch
from
November 11, 2026 13:43
eb224e2 to
c6551db
Compare
zmolnar
force-pushed
the
feature/EXPKITS-1531-embedding-spaces
branch
from
November 11, 2026 15:56
c6551db to
42e1ab1
Compare
zmolnar
force-pushed
the
feature/EXPKITS-1531-embedding-spaces
branch
from
November 12, 2026 07:08
42e1ab1 to
7046dd6
Compare
Szendvics
reviewed
Nov 13, 2026
zmolnar
force-pushed
the
feature/EXPKITS-1531-embedding-spaces
branch
from
November 13, 2026 11:29
7046dd6 to
f0cbfe4
Compare
Szendvics
reviewed
Nov 13, 2026
Szendvics
previously approved these changes
Nov 16, 2026
Task: EXPKITS-1531 Declare comparison space, dimension, metric and subject in embedding metadata. Replace arrival-order selection with explicit space/producer filters and ambiguity handling. Preserve typed active and dormant history, validate vectors and use robust cosine arithmetic across consumers. Add the optional OpChain v1.8 space declaration, regenerate SDKs and bridge, and cover parser, tracker, browser and Plumber regressions. Signed-off-by: Zoltan Molnar <zoltan.molnar@arm.com>
zmolnar
force-pushed
the
feature/EXPKITS-1531-embedding-spaces
branch
from
November 16, 2026 12:50
f0cbfe4 to
1b011bb
Compare
zmolnar
enabled stacked auto-merge (squash)
November 16, 2026 14:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
EXPKITS-1531: Identify embedding spaces and select comparable outputs explicitly.
Change
Before
Arrival order could overwrite embeddings. Equal-length vectors from unrelated spaces could match; unavailable comparisons became numeric zero, and float accumulation or NaN handling could produce false results.
After
embedding-content-typewith explicit selectors. The optional parser declaration advances the OpChain v1 reader from 1.13.0 to 1.14.0 in this layer. The later refactor: EXPKITS-1569 connect inputs to concrete producers #276 migrates Model and OpChain descriptors to format 2.0.0; no legacy embedding-selector alias is introduced here.Testing
Coverage and historical validation
Controlled-vector regressions cover distinct spaces, multiple producers, duplicates, invalid/extreme values, subject swaps and active/dormant history. Model-specific ReID accuracy and physical GPU execution are unverified. Persistent track-subject comparison is completed in #269.
Post-rebase evidence
The 2026-11-16 assembled-stack build, native/WebUI/Plumber tests, SDK/bundle checks
and documentation validation are recorded in the Testing section of #276
at
aad8a7f218a2. These results supplement the earlier coverage above; they are notstandalone local reruns at every lower PR head.
Reproduction commands
From the repository root inside the supported OPK development container, with
the pinned submodules initialized and the normal model/media setup available:
From the host checkout, run
./scripts/gen-doc.shto generate and validate thedocumentation and diagrams in build output.
Links
9e62fe21ccd2.1b011bbf85d4.Part of the breaking, unreleased SDK/product 1.0.0 refactor. Producers and consumers
must use compatible regenerated snapshots. Stable release packaging/publication is separate.