Repository navigation
Prepare Java next compatibility tests for four API changes - #1367
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Focused validation complete. No changed requirements or additional findings.
Source-only review of 22a62a95fdd009364a7eeb02767df964fe3df220. Two independent source reviews; no candidate code, tests, builds or generators executed.
Validation limits:
- Focused context validation only; the coordinator retains the completed source reviews' coverage.
- No tests executed or CI results assessed.
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Approved 22a62a9. The seven component files match their reviewed changes, and the shared exclusion manifest is the exact intended union with no extra or missing entries. Retained multipart and Responses diagnostics coverage remains intact; header assertions still require present headers. The Realtime migration runs only from the trusted base policy for next, checks the exact archived fixture and single old call, rejects links, and leaves current/proposed tests untouched. Coordinator and two independent static reviews found no actionable issues. Hosted CI remains pending; no candidate code or local tests executed.
This combines the compatibility test changes from #1361, #1363, #1365 and #1366 so they can be reviewed and checked against the same revision of
next.The compatibility manifest includes the Assistants and Videos exclusions from both branches. The Videos changes retain the supported multipart and Responses diagnostics cases. The error-handling fixture works with both header signatures. The Realtime detector reads its migration from the base commit and checks the archived fixture before changing the factory call.
All seven other paths match the corresponding component head byte for byte, including the detector and its tests. All 35 local compatibility policy tests passed. The component runs exercised the header and Realtime fixtures against both SDK signatures and verified that deliberately incorrect responses or expectations failed the corresponding assertions.