Repository navigation
Conversation
Castiron-Internal-PR: openai/openai-java-internal#443 Castiron-Source-SHA: cf0af770bb93fa4fd2d4ac8920d124062edefbc1 Castiron-Public-Base-SHA: 9cb3e8c
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
No actionable findings. The changes narrowly remove retired Videos compatibility cases, preserve supported multipart and Responses diagnostics coverage, and simplify transport routing without adding structural complexity.
Source-only review of 04066e8adc98859d5c770471b0f206184f394e6c. Two independent source reviews; no candidate code, tests, builds or generators executed.
Validation limits:
- Source-only review; no tests or commands executed. The staged SDK and future Videos removal are outside this review.
- Source-only review; no code or tests executed.
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed Videos-only compatibility exclusions and mixed fixture cleanup. Supported multipart coverage and Responses error-diagnostic assertions remain intact. No actionable findings.
Hosted CI at review: no failed checks observed. 4 checks pending.
Static review with an independent reviewer; no candidate code or local tests executed.
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Focused validation complete. No candidates were supplied, no requirements changed, and no actionable findings were identified.
Source-only review of 850efc6659f19de8795b1803eb6f06fbd3742a94. Two independent source reviews; no candidate code, tests, builds or generators executed.
Validation limits:
- Focused context validation relying on the coordinator-verified complete source reviews; no code, builds, or tests executed.
- Staged SDK artifacts and the future Videos API removal remain outside scope.
|
Superseded by #1367, squash-merged into |
Java v5 removes the retired Sora Videos API. The Java compatibility check compiles examples of SDK usage from the target branch against the proposed SDK. This change prepares those examples for the removal.
It excludes the remaining 16 Videos-only test files from the compatibility check and removes calls to the retired types from three mixed fixtures. The multipart and Responses diagnostics cases for supported APIs remain covered.
The ordinary compatibility check passed against the prepared baseline, including the structured-output public API checks. Java and Kotlin consumers compiled and ran against the staged SDK JARs.