Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
453e8b8 to
7b45ff8
Compare
markstuart-oai
left a comment
There was a problem hiding this comment.
No actionable findings. The private, typed overload preserves header-value assertions and fails on absent optional headers without adding runtime branching or casts. File size increases from 2,040 to 2,042 lines; no new size-threshold crossing.
Source-only review of 7b45ff833b26ce0c61211a2a55ba4834cb7222c8. Two independent source reviews; no candidate code, tests, builds or generators executed.
Validation limits:
- Source-only review; tests were not executed.
- Source-only review; tests and reported dual-JAR runs were not independently executed.
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed the exact commit statically. The private Optional.toMap() overload preserves all 16 existing header assertions and still fails for absent headers. No actionable findings. Hosted CI is still in progress; no candidate code or tests were executed.
|
Superseded by #1367, squash-merged into |
The API compatibility job compiles the base branch’s tests against the proposed SDK. Sixteen assertions in
ErrorHandlingTestcheck response header values. They currently expect service exceptions to returnHeadersdirectly.Add a private
Optional<Headers>.toMap()overload so the same assertions also compile when the SDK returns optional headers. The helper callsget()and delegates to the existing header conversion. Each assertion still compares the original header name and value.The full 17-test fixture ran against locally installed JARs for both signatures. In separate runs, returning the wrong value in one HTTP response and omitting the header in another failed exactly those two assertions on each version.