Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
markstuart-oai
left a comment
There was a problem hiding this comment.
Focused validation complete; no findings or scope changes.
Source-only review of 2bcfac018e2e8328831ef279c64560ee6fbbfcc5. Two independent source reviews; no candidate code, tests, builds or generators executed.
Validation limits:
- Focused context validation only; no candidate findings were supplied. Prior complete source coverage was not repeated, and tests were not executed.
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed all three changed files, the existing CI discovery and detector staging, and the archived Realtime round-trip fixture. The trusted-base migration is scoped to next PRs/merge groups and the old-to-new factory transition; it verifies original bytes, one exact call and an unlinked archived path. Factory arguments and all three assertions remain intact; proposed sources are untouched. No actionable findings. Hosted CI remains pending. Coordinator and independent static review; no candidate code or local tests executed.
|
Superseded by #1367, squash-merged into |
The Java 5 Realtime session update model renames
SessionUpdateEvent.Session.ofRealtimeSessionCreateRequest(request)toSessionUpdateEvent.Session.ofRealtime(request). The historical round-trip test uses that factory in its expected value.For pull requests and merge groups targeting
next, the compatibility detector reads a migration from the base commit. When the old factory has been replaced, it updates the one call in the archived copy ofSessionUpdateEventTest.kt. It checks that the archived bytes match the base fixture before changing them. The factory argument, all three assertions, and the proposed test stay intact.The complete test passed on both SDK versions. Changing the expected instructions failed the session assertion. Changing the event ID in serialized JSON failed the round-trip assertion on both versions.