Skip to content

Compile the historical Realtime session update test across its factory rename - #1366

Closed
dpiet-oai wants to merge 1 commit into
nextfrom
dp/next-realtime-session-test
Closed

dpiet-oai wants to merge 1 commit into
nextfrom
dp/next-realtime-session-test

Conversation

@dpiet-oai

Copy link
Copy Markdown
Contributor

The Java 5 Realtime session update model renames SessionUpdateEvent.Session.ofRealtimeSessionCreateRequest(request) to SessionUpdateEvent.Session.ofRealtime(request). The historical round-trip test uses that factory in its expected value.

For pull requests and merge groups targeting next, the compatibility detector reads a migration from the base commit. When the old factory has been replaced, it updates the one call in the archived copy of SessionUpdateEventTest.kt. It checks that the archived bytes match the base fixture before changing them. The factory argument, all three assertions, and the proposed test stay intact.

The complete test passed on both SDK versions. Changing the expected instructions failed the session assertion. Changing the event ID in serialized JSON failed the round-trip assertion on both versions.

@dpiet-oai
dpiet-oai requested a review from a team as a code owner November 10, 2026 17:39
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T17:40:39.259852Z 2bcfac0 PR opened
🔒 Security Review ✅ Completed 2026-11-10T17:41:11.611171Z 2bcfac0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focused validation complete; no findings or scope changes.

Source-only review of 2bcfac018e2e8328831ef279c64560ee6fbbfcc5. Two independent source reviews; no candidate code, tests, builds or generators executed.

Validation limits:

  • Focused context validation only; no candidate findings were supplied. Prior complete source coverage was not repeated, and tests were not executed.

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all three changed files, the existing CI discovery and detector staging, and the archived Realtime round-trip fixture. The trusted-base migration is scoped to next PRs/merge groups and the old-to-new factory transition; it verifies original bytes, one exact call and an unlinked archived path. Factory arguments and all three assertions remain intact; proposed sources are untouched. No actionable findings. Hosted CI remains pending. Coordinator and independent static review; no candidate code or local tests executed.

@dpiet-oai

Copy link
Copy Markdown
Contributor Author

Superseded by #1367, squash-merged into next at 5d272f8c630ef3628ab6b23aa7f90d0ee3151589. The merged tree matches the reviewed bundle. Component CI and combined CI passed.

@dpiet-oai dpiet-oai closed this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants