Repository navigation
fix: isolate SDL npm registry from build CFS configuration - #1952
Merged
Merged
Conversation
Changyong Gong (chagong)
approved these changes
Oct 30, 2026
Changyong Gong (chagong)
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the complete diff and pipeline context. The change only resets npm_config_registry in SDL source analysis for CI, Nightly and RC, preserving Build CFS routing, existing pools/SDL configuration, Node versions, permissions and release YAMLs. No blocking code issues found. Azure SDL/CFS checks were still running at review time; this approval does not replace those checks or independently confirm runtime Guardian authentication.
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
npm_config_registrytoextends.parameters.sdl.sourceAnalysisVariablesToResetin CI, Nightly and RC. This isolates SDL/Guardian from the Build-only global CFS registry.Preserve global Build CFS routing, all existing sourceAnalysisPool/pool settings, SpotBugs and network-isolation settings where present, Node versions and permissions. Release YAMLs are unchanged.
Validation
mainatc9438a0719a4ca232d597e8a7b57b1df4a9c2622.previewRun:true+yamlOverridecompilations succeeded for every enabled source definition: 15770, 15776, 23362, with self fixed to that SHA.npm_config_registry: ''inSDLSources_self; all other compiled content is identical.git diff --checkpassed.Scope and limitations
This is the same narrow isolation used in microsoft/vscode-spring-boot-dashboard#453.
Preview compiles but does not execute Guardian/feed authentication. No repository-specific npm6/E401 reproduction or post-fix runtime success is claimed. No build or release was manually queued.