Repository navigation
fix: isolate SDL npm registry from build CFS configuration - #1727
Open
wenyt (wenytang-ms) wants to merge 1 commit into
Open
wenyt (wenytang-ms) wants to merge 1 commit into
wenyt (wenytang-ms) wants to merge 1 commit into
Conversation
wenyt (wenytang-ms)
requested review from
Changyong Gong (chagong),
Sheng Chen (jdneo) and
Jinbo Wang (testforstephen)
as code owners
October 30, 2026 03:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
npm_config_registrytoextends.parameters.sdl.sourceAnalysisVariablesToResetin.azure-pipelines/ci.yml,.azure-pipelines/nightly.yml, and.azure-pipelines/rc.yml. Preserve CI's existing SDL source-analysis pool and leave Build's CFS configuration, Node versions, and feed permissions unchanged.This prevents the pipeline-wide CFS registry environment variable from overriding Guardian's feed-scoped authenticated temporary
.npmrcin injected SDL source-analysis jobs. It follows the validated fix in microsoft/vscode-spring-boot-dashboard#453.Scope audit
Audited all five pipelines on current
main(a114556) using Azure Pipelines template previews:The release pipelines use 1ES templates but compile to release/tag jobs without injected SDL source analysis, so no reset is needed there.
Validation
git diff --checkpassed.previewRun: truewithyamlOverridecompiled all five baseline and final configurations successfully inmseng/VSJava.npm_config_registryoverride only inSDLSources_self.Limitations
This is a preventive isolation fix based on the validated cross-repository issue. No repository-specific HTTP 401 reproduction or post-fix execution run is claimed; preview compilation does not execute Guardian.