Repository navigation
fix: isolate SDL npm registry from build CFS configuration - #1953
Closed
wenyt (wenytang-ms) wants to merge 1 commit into
Closed
wenyt (wenytang-ms) wants to merge 1 commit into
wenyt (wenytang-ms) wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing this duplicate of #1952, which is already merged. Both PRs use the same source branch and head commit; there are no additional changes to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
npm_config_registrytoextends.parameters.sdl.sourceAnalysisVariablesToResetin CI, Nightly and RC. This isolates SDL/Guardian from the Build-only global CFS registry while preserving Build routing, sourceAnalysisPool, existing Windows pool settings, Node versions and permissions. Release YAMLs are unchanged.Validation
Parsed the actual source YAML and checked its diff against main c9438a0. Baseline/final
previewRun:true+yamlOverridecompilations succeeded for enabled definitions 23362, 15770 and 15776 with self fixed to that SHA. Whole-document comparison confirms the only compiled change isnpm_config_registry: ''inSDLSources_self; all other content is identical. Release definitions 21772 and 21773 compiled without SDL source analysis.git diff --checkpassed.Scope and limitations
This is the same narrow isolation used in microsoft/vscode-spring-boot-dashboard#453. Preview compiles but does not execute Guardian/feed authentication; no repository-specific npm6/E401 reproduction or post-fix runtime success is claimed. No build or release was manually queued.