Repository navigation
Fix TypeScript execution and Calls/PBT contracts after full review - #520
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| return "$revision@sha256:${callsExternalFrontendRuntimeDigest(realDirectory)}" | ||
| } | ||
|
|
||
| private fun callsExternalFrontendRuntimeDigest(frontendDirectory: Path): String { |
Move Date routing from the generic catalog to the dispatcher while preserving direct-target precedence and original-call completion. Add focused dispatcher contract tests. Runtime checks were not run at the user request.
Keep joined runtime-kind metadata separate from payload construction. No semantic change; verification was static only at the user request.
Preserve array dimensions, literal reflexivity, structural class alternatives and auxiliary requirements. Add focused unexecuted regression source. Independent static patch verification only; no compiler, tests, JVM or containers were run.
Decompose result ITE payloads and guards from current memory. Add five unexecuted API regression contracts and clarify existing test phases and numeric comment. Independent static verification and targeted fixture repair only; no compiler, tests, JVM or containers were run.
Correct wrapper-bearing conditional boxing and primitive literal, alias, and intersection array descriptors. Add focused regression source and separate existing test phases. Independently reviewed and statically verified; compilation and runtime checks were not run under the user restriction.
Copy the mutable artificial-local registry for each cloned state. Add a focused bidirectional add/remove isolation regression source and clean local comments and test phases. Independent static review and patch verification passed; compilation, tests, and runtime checks were not run.
Reuse guarded code-unit population and the existing private length reader while preserving distinct backing allocation and state mutation order. Name the input register index and separate test phases. Independently reviewed and statically verified; compilation, tests, solver, and replay were not run.
Reject unsupported active numeric conversions and retain represented wrapper alternatives. Add regression source; verification is static only and no tests were executed.
Use the selected right payload in mixed-kind equality and add a focused regression source case. Apply named arguments and staged predicates in PBT value encoding. Verification is static only.
Isolate runtime limitation callbacks like unknown-call observation. Add a regression source scenario asserting callback invocation and preserved metadata. Independent static verification only; no tests executed.
Preserve manifests with repeated project IDs by selecting the project that owns the globally unique function. Add focused regression source and clarify manifest validation and build diagnostics. Independent static verification only.
Check the existing encoding contract before NaN and bound membership handling. Add direct predicate regression source for malformed tags and noncanonical finite bits. Independent static verification only.
Select public default exports and direct named declarations marked DEFAULT while preserving source-origin metadata. Add ordinary alias and source-backed named-function regression cases. Independent static verification only; no tests executed.
Reject identifier-ignorable controls and malformed integer encodings. Enforce string primitive types in Istanbul reports while preserving nullable path fallback. Add focused regression source and clarify validation code. Independent static verification only.
CaelmBleidd
force-pushed
the
caelmbleidd/ts-quality-review-20261014
branch
from
October 15, 2026 12:46
3fa1024 to
b92f23a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct TypeScript execution, Calls and PBT defects found during the bounded source review, and simplify the affected code around explicit ownership, evaluation order and supported behavior.
The JacoDB companion UnitTestBot/jacodb#443 is merged into
neo. The dependency now pins current mergedneoat7db549ef2a6c2cd05e9403e3e2e7087df7c5fcc2, which contains #443 and the subsequent frontend fixes #438–442. All eight JitPack modules for this exact SHA are published. The shared revision keeps the frontend and Kotlin converter aligned, including compact lexical-environment references; bounded source review found no additional USVM adaptation needed. The companion suppliesisSuperCallmetadata and corrected generic constraints. The newer merges also address optional-chain fallback CFGs, property source spans, ambient namespaces and deep comma-expression lowering.Rebased onto current
mainatd7b3d2111bec8f57ccf853e0e29f5f8fa566d124. The rebase preserves the prior source tree exactly and drops redundant intermediate JacoDB pins already superseded by main. Conflict resolutions retain upstream observer events, remainder semantics and prepared class harness behavior alongside the reviewed fixes.Validation: automatic CI 38737176045 passed all jobs at
b92f23a6aa24d54c0cb7ea0493e9e9a4321545fb: TS/Calls, PBT, core, JVM, Python and lint. Actual Detekt output and code scanning confirm 19 of the 20 Calls warnings fixed; the remaining digest NestedBlockDepth is addressed separately in #522. No lint policy, baseline or suppression changed. All 21 moved experiment tests actually passed; independent source comparison also preserves their 17 TempDir parameters, eight helper bodies and fixture strings. The original native-JavaScript replay oracles are retained. ComputedSymbol.hasInstancesource fixtures assert the precise earlier frontend boundary; they do not claim runtime guard coverage.The change also received bounded subagent review, independent inspection of risky semantic changes, range-diff inspection and full-range
git diff --check. No local JVM, Gradle, Node/npm, compiler, tests, solvers or containers were started under the requested resource restriction. The branch was rebased ontomaind7b3d2111before publication and merged ascac798cb2c5cda4e3cd9da6c0ea1fa2865dcbcc5.