Repository navigation
Fix ETS and TypeScript frontend contracts and simplify reviewed code - #443
Merged
Merged
Conversation
Name modifier encodings and separate test setup and assertions. Preserve wire values and test content. Verification was static only at the user request.
Name dimensional arguments and separate canonicalization actions from assertions. Preserve existing scenarios and expected types. Verification was static only at the user request.
Review signature and entity contracts without production changes. Normalize the assigned file test import and logical phase spacing. Independent static verification only; no compiler, tests, JVM or containers were run.
Apply the agreed logical-block spacing. Static diff inspection only; no runtime processes were launched.
Apply agreed Kotlin style to reviewed expression and statement models. Verification is static source inspection only.
Initialize file ownership recursively while preserving namespace and method owners. Add nested ownership regression source. Independent static verification only; no tests executed.
Distinguish default declaration syntax from live aliases and retain type-only export metadata in diagnostic rendering. Correct import documentation. Independent static verification only.
Reject nonexistent endpoint IDs at construction and retain the existing nonempty-block boundary guard. Simplify predecessor generation and add focused valid and invalid boundary regression source. Static verification only.
Accept ClassValueRef in the existing immediate constructor field and add a raw JSON decoder regression source. Remove inactive operator and model comments. Independent static verification only; no tests executed.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TypeScript lowering and ETS model defects found during a class-by-class review of
jacodb-etsandts-frontend, and make the affected code follow consistent, explicit control flow.Rebased onto
neoat7b3ff240da5c79a365db175afbc5c0aab09366df. All 60 review commits retain equivalent patches after rebase; an independent static check also confirmed that the upstream constructor parameter-property binding fix remains intact.The initial automatic CI run reported an unused import and two TypeScript narrowing errors. A subsequent, independently inspected commit removes the import and explicitly narrows namespace bodies and catch binding patterns.
A subsequent CI run built the frontend, then reported 15 frontend test failures. Follow-up commits repair the native iterator oracle, fixture and DTO matcher errors, and assertions for explicit unsupported boundaries. They also fix a production defect: inferred generic binders now preserve their immediate declared constraint (
T extends U) instead of reducing it to a transitive base constraint. The generic fix received independent static verification; the original failing regression is retained.Local validation: full-range
git diff --check, range-diff inspection, and independent static review of substantive fixes and the rebase overlap. Per the requested resource restriction, no JVM, Gradle, Node/npm, compiler, tests, solvers or containers were started locally.Automatic remote CI at
eecc7513f6b761b46700d1776adedab664eefadfis green: 747/747 frontend tests, ETS Kotlin tests, lifecycle, and core on JDK 8, 11 and 19; result publication also passed. Run: https://github.com/UnitTestBot/jacodb/actions/runs/38702257262. This is JacoDB CI evidence; the USVM companion still needs a successful dependency download and its own checks.This PR supplies the
isSuperCallmetadata consumed by the companion UnitTestBot/usvm#520, which pins JacoDB commiteecc7513f6b761b46700d1776adedab664eefadf. Merge this JacoDB change before integrating the USVM companion; no artifact build has been requested manually.