Repository navigation
Reduce nesting in external frontend digest hashing - #522
Merged
Merged
Conversation
CaelmBleidd
force-pushed
the
caelmbleidd/calls-digest-detekt-20261015
branch
2 times, most recently
from
October 15, 2026 13:24
0a60a1e to
fc05257
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/calls-digest-detekt-20261015
branch
from
October 15, 2026 13:59
fc05257 to
2de7b7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External frontend runtime hashing still exceeds Detekt's nesting limit after #520. Extract the framing, streaming read and size check for one file into a private helper, keeping the caller's sorted traversal shallow.
The digest protocol, shared buffer, validation order, stream closure, error text and final hex encoding are unchanged. This is a one-file follow-up against
main68f49fcdce5bd56120113c408f4826d0660c2cb8, including merged #520 and #517.Validation: the final rebased head
0a60a1e250bb083918fd10812ca005a343beb185is running in automatic CI 38741132555. Prior CI 38738817218 passed TS/Calls, PBT, core, JVM, Python and lint at602544388; actual Detekt output had zero Calls findings. The changed engine file is byte-identical across the final rebase, so the new run checks integration with the fresh main. Independent static review and exact moved-block comparison preserve the hash protocol and resource lifecycle;git diff --checkpasses. No local JVM, compiler, tests or containers were run under the requested resource restriction.