Repository navigation
Fix Meson column metadata propagation - #595
Merged
Merged
Conversation
|
coverage: 99.714%. remained the same — fix-meson-column-metadata into master |
SRombauts
force-pushed
the
fix-meson-column-metadata
branch
from
October 16, 2026 08:51
908eac3 to
fcffedd
Compare
Expose enabled origin-name APIs through sqlitecpp_dep so consumers receive the same metadata feature definition as the library.
Add a consumer that checks the feature definition and calls both origin-name APIs. Run it with shared and static SQLite fallback builds and system SQLite, retaining the metadata-disabled CI coverage.
SRombauts
force-pushed
the
fix-meson-column-metadata
branch
3 times, most recently
from
October 16, 2026 09:00
de927a2 to
1e4dd18
Compare
Describe the metadata feature instead of naming a single accessor. Both build systems require SQLite itself to support column metadata.
Treat skill and agent-instruction maintenance as separate documentation work. Keep consumer tests with the build and CI changes that run them, and document the Meson metadata coverage.
Record the consumer API visibility fix in the unreleased changelog.
SRombauts
force-pushed
the
fix-meson-column-metadata
branch
from
October 16, 2026 09:24
1e4dd18 to
a02b4b5
Compare
SRombauts
added a commit
that referenced
this pull request
Oct 17, 2026
Fixes #555. Add `Statement::getColumnTableName()` and `Column::getTableName()` under `SQLITE_ENABLE_COLUMN_METADATA`, so callers can retrieve the source table without preparing another statement. The API preserves SQLite's null and pointer-lifetime semantics. Validation: 72 tests pass with CMake/GCC, CMake/Clang ASan+UBSan, and Meson with metadata enabled; 69 pass with metadata disabled. CMake examples and an independent consumer also pass. After rebasing onto #595, the public Meson consumer checks both table-name APIs; system/shared and bundled/shared/static configurations pass, as does bundled/static with metadata disabled. The project-settings lint findings match the baseline; Windows/macOS and Doxygen were not run. Prepared and validated with OpenAI Codex. The changelog is in a separate final commit, as requested by the contribution workflow.
This was referenced Oct 22, 2026
SRombauts
added a commit
that referenced
this pull request
Oct 23, 2026
Backport #595 to the C++11 maintenance branch: propagate `SQLITE_ENABLE_COLUMN_METADATA` through the public Meson dependency so consumers can call the existing origin-name APIs. Add an independent Meson consumer test for enabled/disabled metadata and CI coverage with bundled shared/static and system SQLite. No new public API and no SQLite version requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in Meson found while reviewing the other PR #594 Add table-name accessors for result columns
Propagate
SQLITE_ENABLE_COLUMN_METADATAthrough the public Meson dependency so consumers can use the enabled origin-name APIs. Add a consumer regression test and CI jobs for shared/static SQLite fallback builds and system SQLite, retain metadata-disabled coverage, and clarify the CMake and Meson option descriptions.Validated locally with metadata enabled and disabled, shared and static fallback builds, and a custom assertion handler. The consumer fails to compile without the propagation fix.