Repository navigation
Conversation
Add the Statement and Column APIs from #594 to the 3.4.x maintenance line, including metadata lifetime and reprepare tests.
Propagate the compile definition to dependents, and test both origin-name and table-name APIs with metadata enabled and disabled.
Record the C++11 backport for maintenance release notes.
|
coverage: 99.715% (+0.002%) from 99.713% — 594-feature-backport-table-name-cxx11 into sqlitecpp-3.4.x |
Owner
Author
|
I want to thanks all the team for this. We really need to stay in C++ 11 (old systems are still used, need to stay in C++11 version). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
Statement::getColumnTableName()andColumn::getTableName()from #594 to the C++11-compatible 3.x maintenance line, for the planned 3.5.0 release.Also port the Meson metadata propagation fix from #595 and add a consumer test.
C++11-compatible unit tests cover invalid indices, expressions, moved statements, retained columns, and automatic reprepare (this last one might not be a good idea, because it's adding a dependency on a newer SQLite database version).