This repository was archived by the owner on Oct 17, 2026. It is now read-only.
Repository navigation
feat(authoring): allow agent_drive observations on Windows, RDP, and Citrix - #47
Merged
Merged
Conversation
…ations AuthoringObserveV1 rejected any windows, rdp, or citrix observation that wasn't coach_only, so no producer could advertise agent drive there. The rule now follows what each surface can do: any backend can advertise agent_drive, and rdp and citrix observations are screen-only and carry no tree. A producer can still send coach_only. Signed-off-by: Richard Abrich <richard.abrich@mldsai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The authoring observe contract rejected any Windows, RDP, or Citrix observation that advertised agent_drive. This PR removes that rule. RDP and Citrix observations are screen-only now: the validator rejects them only when they carry a tree. Coach-only observations still validate.
Part of making agent-driven recording work on native Windows and over RDP/Citrix (Flow, agent, and Desktop PRs to follow).
Tests:
pytestpasses locally (669 passed).