This repository was archived by the owner on Oct 17, 2026. It is now read-only.
Repository navigation
feat(authoring): let the local agent drive recording on Windows, RDP, and Citrix - #77
Merged
Merged
Conversation
… and Citrix serve --authoring turned every native Windows, RDP, and Citrix session into a CoachOnlySession, so the agent could only tell the person what to click. New flags pin a driver through Flow's build_backend, the factory replay uses: - --windows-agent-url: WindowsBackend over a Flow Windows agent server the operator already started (token from OAFLOW_AGENT_TOKEN). - --remote-window / --remote-window-title / --citrix: the local RDP or Citrix client window, screen-only. - --authoring-screens scrubbed|unscrubbed: an operator-only switch that adds a screen tool returning the pinned frame, scrubbed through the repair scrubber unless the operator chose unscrubbed. Off by default. Windows with nothing pinned is still coach-only, and the hosted mailbox client is unchanged. Observe drops any tree for rdp/citrix and keeps a pinned Windows observation when an older openadapt-types still has the coach-only rule. Signed-off-by: Richard Abrich <richard.abrich@mldsai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serve --authoringforced CoachOnlySession for windows/rdp/citrix (authoring.py:136-137 and :675-681 on main), and the README said a person has to do the recording there.New flags pin a driver through Flow's
build_backend:--windows-agent-url(token from OAFLOW_AGENT_TOKEN). Connects only to a Windows agent server the operator started. It never spawns one.--remote-window/--remote-window-title/--citrix: the local client window, screen-only.--authoring-screens off|scrubbed|unscrubbed(default off). Adds ascreentool.scrubbeduses the repair scrubber and shares nothing if scrubbing fails.Unpinned Windows stays coach-only. The hosted mailbox client stays coach-only, because hosted clicks are node_id only. A compat path keeps pinned Windows/RDP/Citrix observations working with openadapt-types releases that still have the coach-only rule.
Depends on OpenAdaptAI/openadapt-flow#527 (tests/test_authoring_native.py skips until a Flow release has SCREEN_ONLY_KINDS) and OpenAdaptAI/openadapt-types#47.
Local: 468 passed, 10 skipped against the released Flow. The 10 native tests pass against the Flow branch. ruff is clean.