Repository navigation
tests: gate WOLFSSH_LOCAL calls on TEST_INTERNAL - #1316
Open
ejohnstown wants to merge 2 commits into
Open
ejohnstown wants to merge 2 commits into
ejohnstown wants to merge 2 commits into
Conversation
test_wolfSSH_SCP_SendRecursiveEntry() drives wsScpSendCallback(), a WOLFSSH_LOCAL symbol. The autotools api.test defines WOLFSSH_TEST_INTERNAL and links the test library, so it still runs there. The MSVC api-test project links the DLL import library, where the symbol is not exported, so the test now compiles to its stub. - fixes LNK2001 on wsScpSendCallback in the DLL Release build
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1316
Scan targets checked: wolfssh-bugs
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
The OsshCert_* tests and test_wolfSSH_KeyboardInteractive_emptyPrompt() call WOLFSSH_LOCAL functions, which the winvs DLL import library does not export. Gate them on WOLFSSH_TEST_INTERNAL, like the SCP recursive-entry test, so a DLL build with either feature still links. - stub the OsshCert_* tests when WOLFSSH_TEST_INTERNAL is off - gate the RSA and ECDSA certificate vectors, which only those tests use - stub test_wolfSSH_KeyboardInteractive_emptyPrompt() the same way
ejohnstown
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MSVC
api-testproject links the wolfSSH DLL import library, whereWOLFSSH_LOCALsymbols are not exported, sotests/api.ctests that call library internals fail to link in aDLL Releasebuild. The autotoolsapi.testis built withWOLFSSH_TEST_INTERNALand keeps running them all. Supersedes #1303.test_wolfSSH_SCP_SendRecursiveEntry()onWOLFSSH_TEST_INTERNAL; this is thenightly-QNX-testslink failureOsshCert_*tests, their RSA/ECDSA vectors, andtest_wolfSSH_KeyboardInteractive_emptyPrompt()the same way, latent until a winvs config enables those features