Repository navigation
tests: guard WOLFSSH_LOCAL calls on Windows - #1303
ejohnstown wants to merge 1 commit into
Conversation
The winvs test projects link the wolfssh.dll import library, which does not carry WOLFSSH_LOCAL symbols, so api.c tests that call library internals compile only where the autotools build links them in through libwolfssh_test.la. Stubs keep the call list in wolfSSH_ApiTest() flat. - test_wolfSSH_SCP_SendRecursiveEntry() drops out on USE_WINDOWS_API, matching its symlink sibling; this was the unresolved wsScpSendCallback in the nightly-QNX-tests DLL Release link. - The OsshCert_* tests, which drive OsshCertParse() and friends directly, take the same guard. - test_wolfSSH_KeyboardInteractive_emptyPrompt() takes it for SendUserAuthKeyboardRequest().
There was a problem hiding this comment.
🟢 Approval recommended
The guards consistently prevent unavailable private-symbol references while preserving existing test registration.
0 open findings
What changed in this PR
Guards tests that call private WOLFSSH_LOCAL symbols from Windows DLL builds, preventing unresolved linker symbols.
Changes:
- Disables affected SCP, OpenSSH certificate, and keyboard-interactive tests under
USE_WINDOWS_API. - Provides empty test stubs so the test runner remains unchanged.
| File | Description |
|---|---|
tests/api.c |
Adds Windows guards and fallback stubs for tests calling private symbols. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1303
Scan targets checked: wolfssh-bugs
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
|
Closing in favor of #1316, which now carries all three guards using |
The winvs test projects link the wolfssh.dll import library, which does not carry
WOLFSSH_LOCALsymbols. Threetests/api.ctests call library internals directly and relied on the autotools build linkinglibwolfssh_test.la; they now sit behind!defined(USE_WINDOWS_API)with empty stubs, the same guardtest_wolfSSH_SCP_SendSymlinkReject()already uses.test_wolfSSH_SCP_SendRecursiveEntry(): the unresolvedwsScpSendCallbackfailing thenightly-QNX-testsDLL Release link.OsshCert_*tests andtest_wolfSSH_KeyboardInteractive_emptyPrompt(): same pattern, latent until a winvs config enablesWOLFSSH_OSSH_CERTSor keyboard-interactive.