Skip to content

Retire the agent-commit Bats suites where Go covers them #858

Open

Description

@tbhb-agent

Problem

The Bats suites tests/skills/agent-commit/workflow.bats and base-merge.bats still test unattended-mode and base-merge shell behavior that agentrepo commit --unattended now owns, so they duplicate the Go tests and must shrink to the cases that still need a real shell or the fallback.

Part of #322, within #588. Child 09 in #322's Children list. Deletes test cases only; no skill source or generated skill changes.

Acceptance criteria

  1. AC1: Given every case in tests/skills/agent-commit/workflow.bats and tests/skills/agent-commit/base-merge.bats, when the pull request is read, then each case is marked deleted with the Go test that covers it, or kept as a wrapper, fallback or real-shell case with the reason, and no case is unaccounted for.
  2. AC2: Given the merged change, then every case marked deleted is absent and every kept case passes.
  3. AC3: Given the Go tests named for the deleted cases, when CI runs, then they pass on macOS, Linux and Windows.
  4. AC4: Given the generated skills, then nothing changes and mise run check-generated-skills passes.

Scope and non-goals

Scope: tests/skills/agent-commit/workflow.bats and tests/skills/agent-commit/base-merge.bats and a case ledger in the pull request.

Non-goal: changing any wrapper, fallback or generated output. Non-goal: removing the frozen fallback before the N-2 window closes. Out of scope: Bats suites for other skills.

Approach

Meet AC1 to AC4. List the cases, match each to a Go test from children 01 to 06, delete the duplicates and keep the wrapper and fallback cases. The mechanism is the implementer's choice.

Dependencies

Blocked by: #855 and #856.

Size

S. One pull request, deletions only. Estimated code SLOC counted with scc rules on the case files: 546 lines of code at most, under the 800 limit; none of it is in a generated path.

Verify plan

  • AC1: the ledger in the pull request lists every case in tests/skills/agent-commit/workflow.bats and tests/skills/agent-commit/base-merge.bats.
  • AC2: the Bats run for the remaining cases passes and the diff shows only ledger-marked deletions.
  • AC3: the CI matrix jobs for the named Go tests.
  • AC4: mise run check-generated-skills passes with no diff.
  • Definition of done: D1 each AC is verified at the merged head, with the commands and results cited in the pull request's Verification. D2 an independent review approves the exact merged head, and every finding has a recorded disposition. D3 required checks pass with no gate loosened. D4 the leak scans the repository specifies are clean, and every post made for this work passes the per-post leak review before it is posted. D5 every commit is signed. D6 the documentation matches the change or the Verification says why there is no impact. D7 every commit has an Assisted-by trailer and the pull request has the provenance:agent-assisted label. D8 the pull request stays within the size limits. D9 follow-ups are filed as issues and listed under Related. D10 the merge closes the issue through a closing reference, the board shows Done, and the final Status: comment names the merge commit.

Risks

Deleting a case whose Go equivalent is weaker loses coverage; the ledger names the covering test and the review checks it. Undo: revert the change, which restores the cases.

Operator authority

None.

Activity

  1. tbhb-agent commented on Oct 27, 2026

    @tbhb-agent
    ContributorAuthor

    Refinement: READY — Retire the agent-commit Bats suites where Go covers them
    Model: gpt-6-astra

    Child 09 Retire the agent-commit Bats suites where Go covers them

    Verdict: READY

    Checked: The unchanged suites total 603 physical lines, bounding this deletion-only scope below 800. The ledger includes redesign and merge-parent verification behavior represented at tests/skills/agent-commit/workflow.bats:328 and tests/skills/agent-commit/base-merge.bats:262.

    AC1–AC4 have matching checks. Dependencies supply replacement behavior and wrapper parity; retained shell cases remain permitted. Scope, authority, risks and undo are consistent.

    Gaps: None.

    Split: None. S remains credible.

    Definition of done

    The definition of done for this issue (Chore). Tick each item and give its evidence.

    • D1 The author verified each AC on the merged head, and the Verification section of the pull request cites each AC ID with its evidence: the command and its result, or a link.
    • D2 An independent reviewer approved the exact merged head, and the author resolved each finding or filed it as a follow-up.
    • D3 The required checks pass on that head, and any loosened gate has the owner's approval of that exact head.
    • D4 The leak scans come back clean: gitleaks, devtools' check-leaks.sh with the repository's private-strings list, and the leak review of each post.
    • D5 The author signed each commit, the squash included.
    • D6 The docs match the change (README, docs/, CHANGELOG or help text), or the Verification section says "No doc impact" and why.
    • D7 The commits and the squash have Assisted-by trailers, and the pull request has the provenance:agent-assisted label.
    • D8 The pull request stays within the size limits, or the owner approved its exact head over the hard limit.
    • D9 The author files follow-ups and deferred findings as issues with at least a Problem and numbered AC and lists them under the Related section of the pull request. Any work left in the code links its issue.
    • D10 The merge closes the issue through a closing reference and the board shows Done. The final Status: comment names the merge commit.
    • devtools-1 mise run check is green, and so are the coverage floors mise run cover-go-check and mise run cover-py-check, which check doesn't run.
    • devtools-2 A change to skill sources under packages/agents/source/ commits what mise run generate-skills, then mise run skill-tokens, then apm install rewrite, in that order, and check-generated-skills (part of lint) passes.
    • devtools-3 A consumer-visible change (the vendored payload, a skill, a reusable workflow, a task or a pin) has its consumer steps in docs/agent-skills-migration.md or the adoption docs, or the PR's Verification says "No consumer impact" and why.

    Round: 3 of 3

  2. added theissue type on Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    refinement:readyPassed the Definition of Ready; may be picked up

    Type

    Fields

    Priority

    None yet

    Work type

    None yet

    Projects

    • Status
      Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions