Repository navigation
feat(cli): add SQL preview and job status commands - #127
Draft
rtiman-spotify wants to merge 3 commits into
Draft
rtiman-spotify wants to merge 3 commits into
rtiman-spotify wants to merge 3 commits into
Conversation
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds data sql preview/status with direct regional Metrics HTTP APIs, JSON query input, immediate job references and optional bounded --wait polling. Handles pending/running/retry-pending/throttled jobs and terminal failure/cancellation; preserves job references when waiting fails. Inspecting a failed job is a successful status read.
Dependency
Depends on #122. The fork branch shares the exact foundation commits; its main-targeted diff includes them until the foundation lands. Kept draft; do not merge out of order. The separate schema PR builds on this one.
Safety
Explicit preview starts a query and may incur warehouse costs. Never replays a preview or automatically cancels its remote job. Transport/5xx/malformed-success creation responses report an unknown outcome. Dry-run validates locally before authentication and performs no HTTP calls, writes or telemetry. This is not physical discovery or an onboarding run.
Verification
Node 24, pnpm build and full pnpm qa passed after current-main auth integration. MSW command tests cover job lifecycle, bounded polling/timeouts, malformed/lost responses, local validation and auth-free dry-run. Existing E2E regression runs in CI; no live warehouse/API compatibility claim.
Checklist
Related: https://spotify.atlassian.net/browse/SLMD-1921.