Repository navigation
feat(cli): expose SQL schema without sample row output - #128
Draft
rtiman-spotify wants to merge 4 commits into
Draft
rtiman-spotify wants to merge 4 commits into
rtiman-spotify wants to merge 4 commits into
Conversation
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds data sql schema --name sqlJobs/... using the existing GetSampleRows endpoint. Outputs only known schema fields, column issues, table issues and pending/failed result metadata; never prints raw sample results, rows or unrelated job statistics.
Dependencies
Depends on #127 and transitively #122. The fork branch contains those exact commits; its main-targeted diff includes both prerequisites until they land. Kept draft; do not merge out of order.
Privacy and semantics
The backend endpoint may send rows over the wire: this is strict client-side projection, not a server no-row guarantee. Row data is not printed, logged, persisted or sent to telemetry/models. A pending/failed result is inspected successfully with schema:null and explicit state; HTTP/authentication/malformed-response errors exit nonzero. No new queries, polling or retries. Dry-run validates names without auth/HTTP/writes/telemetry.
Verification
Node 24, pnpm build and full pnpm qa passed. 31 focused MSW tests cover JSON/human sample-row non-disclosure, projection of unknown nested fields, result oneofs, malformed schema, pending/failure semantics, permissions/missing jobs and auth-free dry-run. Existing E2E regression runs in CI. No live API compatibility claim.
Checklist
Related: https://spotify.atlassian.net/browse/SLMD-1921.