Repository navigation
feat(cli): add fact table list get and create commands - #123
Draft
rtiman-spotify wants to merge 3 commits into
Draft
rtiman-spotify wants to merge 3 commits into
rtiman-spotify wants to merge 3 commits into
Conversation
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds data fact-tables list/get/create using existing Metrics HTTP APIs. Supports pagination/filter/order/deleted visibility, explicit bounded --all, resource JSON input and optional caller-selected IDs. Create sends the resource body directly and never automatically retries. Lifecycle state/errors/schema-validation jobs remain visible.
Dependency
Depends on #122. This fork branch shares the foundation commits; the main-targeted diff includes them until it lands. Kept draft; do not merge out of order.
Safety and limits
Strict input validation rejects unknown/output-only fields and column annotations. skipSqlPreview and column.type inputs are intentionally unsupported so creation uses backend SQL/schema validation. Lost/invalid create responses report unknown outcome and preserve a supplied ID for manual lookup. No batch/recovery/approval workflow, updates or deletion.
Verification
Node 24, pnpm build and full pnpm qa passed against current-main auth. 179 focused command/input MSW tests pass. Existing E2E regression runs in CI; no live API compatibility claim.
Checklist
Related: https://spotify.atlassian.net/browse/SLMD-1921 and https://spotify.atlassian.net/browse/SLMD-1934.