Repository navigation
feat(cli): suggest fact table columns from an explicit schema - #129
Draft
rtiman-spotify wants to merge 4 commits into
Draft
rtiman-spotify wants to merge 4 commits into
rtiman-spotify wants to merge 4 commits into
Conversation
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds data fact-tables suggest-columns --from-file schema.json through the existing Metrics SuggestFactTableColumns HTTP API. Reuses the existing fact-table command group, validates explicit schema metadata and returns proposed mappings without creating or certifying resources.
Dependencies
Depends on #123 and transitively #122. The fork branch contains those exact commits; its main-targeted diff includes the prerequisites until they land. Kept draft; do not merge out of order. There is no duplicate fact-table command group or CRUD implementation.
Safety and limits
Accepts schema column names, optional supported enum types and repeated flags; rejects rows, unknown fields and new column annotations. Handles suggestion/error oneofs and treats application errors on HTTP 200 as failures. It sends no sample rows, performs no writes and never silently starts an onboarding workflow. Auth-free dry-run makes no HTTP/model requests.
Verification
Node 24, pnpm build and full pnpm qa passed. Focused MSW command/input coverage includes schema validation, regional/profile auth, HTTP/application errors, malformed results and auth-free dry-run. Existing E2E regression runs in CI. No live API/model compatibility claim.
Checklist
Related: https://spotify.atlassian.net/browse/SLMD-1921.