Repository navigation
Conversation
fffonion
added this pull request to stack #8
October 18, 2026 09:59
This was referenced Oct 18, 2026
fffonion
force-pushed
the
feat/tool-plugin-effects-draft
branch
from
October 18, 2026 12:27
e001dd9 to
bb0fcc6
Compare
Base automatically changed from
refactor/production-foundation-consolidated
to
master
October 18, 2026 12:41
fffonion
force-pushed
the
feat/tool-plugin-effects-draft
branch
from
October 18, 2026 12:41
bb0fcc6 to
c5a4da3
Compare
Update rustscript-vm and pd-host-function to b5066dd92fcd7c07df57e3ec2c29dbcf8c19c390 so one CREATE TRIGGER is accepted through the production AgentRunner policy. Multi-statement SQL stays rejected.
Keep one validation, the original parser error, and the fault-only rejection log.
The helper is not a test. Its only caller is managed_authority_tests, included under the same workspace-io-fault cfg. Default unit builds otherwise reject the unused definition.
…9c390 The pin guard still required d9387f98 after the authorized SDK upgrade. Keep the full SHA, HTTPS remote, three lock sources, stale B1 rejection, and abbreviation checks, and reject the prior SDK explicitly.
Recheck the same RunCancellation after the crash seam and before the external call. Keep the committed model.requested row and return the existing typed cancel or deadline failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Draft tools-plugin/effects plan on master. Production PR #6 is merged; PRs #4/#5 remain closed unmerged, with original source
9296effpreserved. This PR remains Draft and unmerged.Current accepted implementation
Head:
77653d574ebd4f0c451e443b5899fb5970f14cb6; base: master. Original-cancellation recheck after provider request persistence, on top of SDK intake and test/documentation corrections. SDK intake pins official Coreb5066dd92fcd7c07df57e3ec2c29dbcf8c19c390. In addition to bounded resolver backtracking and the test-only native HTTPS/persistence-gate lifecycle fixes, this head includes the T08/T10 managed synchronous effect transaction and restart path:Feature review and scoped correction review are accepted, with M1–M3 closed. Final integration review is accepted with carried advisories, no new blockers. Six feature advisories and two TLS advisories remain recorded; no OS sandbox, 32-bit support or arbitrary third-party process-isolation guarantee is claimed.
Current-head validation
Normal cherry-pick without conflicts or manual source edits. Exactly 48 of 49 feature paths equal the reviewed feature bytes; store.rs equals the ordinary automatic merge with the accepted instance gate. TLS, original gateway/lifecycle tests and manifests match the Draft predecessor.
54 runtime batches, 1446 feature/profile-specific executions passed: Debug 723, Release 723. Actual Cargo JSON, official d938 SDK, features/profile, ELF listing, selected test names and inner/wrapper return codes are bound to this head. Coverage includes managed/default/fault paths, gateway, full native HTTPS, PersistBlock, resolver/manifest/schema and original lifecycle. Lifecycle is 40/40 in all four groups. Schema drift, fmt, strict all-feature Clippy including lib unit cfg, and committed-range whitespace passed. (Evidence belongs to integration baseline
2b3d80be53b538e76115751aa3cd21f2d7a061f0; not counted as new eb92 runtime qualification.)Previous-head CI run 39180074454 failed lib 440 / 2 / 6 before integration targets. Controlled tests establish ambient-umask-dependent fixtures and the AuthStore private-home rejection; actual GHA umask remains unobserved. The published test-only fix
eb92d8cfb59d3a937381413655102941b80dde55explicitly sets parent/home0700 and config0600 in two fixtures, preserving real Native authorization/default selector and all original assertions. Independent Grok review is CLEAN (no blocking or advisory). Full all-feature lib Debug and Release each pass 442 / 0 / 6 at umask022 with default concurrency; both exact tests pass at022 and077; 41 Native/managed neighbors, fmt and strict all-feature Clippy including unitcfg pass.Previous-head CI run 39183301675 failed documentation consistency 6 passed / 3 failed after actual CI lib 442 passed / 0 failed / 6 ignored, including both repaired Native workspace fixtures. Published documentation-only fix
ce9ad25c95aa02092243f9959b51e7cea7345575adds the realmanaged_workspaceNative-field contract and primary-onlyRUSTSCRIPT_AGENT_MANAGED_WORKSPACEpath setting (no invented alias). Onlydocs/configuration.mdchanged; production and test guards remain unchanged. Actual documentation RED reproduced 6 / 3, then Debug/Release x default/all-features each passed all9 tests with independent inner/wrapper0. Parent source/doc review, fmt, docs-target strictClippy and actual remote-PR-base whitespace gates accepted.Previous-head CI run 39184901364 failed in managed commit/recovery startup fixtures: 34 passed / 2 failed. Actual CI lib passed 442 / 0 / 6 and docs consistency passed all9, confirming the preceding repairs. Both new failures panic on
var_os(key).unwrap()before spawning the normal gateway binary: fixtures require all seven scratch aliases plus optionalCEF_PATH, while the workflow explicitly supplies three scratch aliases. The first missing remote key is unobserved. Published test-only fix3250ef5928a571b6ae1687923e3d7aa9af691b4bderives seven child scratch aliases from the required assigned root and forwards optional CEF only when present. Controlled CEF-absent exact cases each transition RC101 to RC0 and execute real binary health/store/owned shutdown or all three startup denials; the first missing GHA key remains unobserved. Full related target passes Debug/Release with default features (21 each) and all-features (38 each, including two new helper regressions). Original assertions and deadline are unchanged; independent Grok review is CLEAN for this startup-fixture scope, with no blockers or advisories. Later targets are not run; no unchanged-head rerun or full-project success is claimed.Previous-head CI run 39187950532 failed RSS tool architecture: 8 passed / 1 failed (
production_rust_does_not_match_public_tool_names_for_execution). Actual CI lib passed 442 / 0 / 6, docs all9, and managed commit/recovery all38, confirming the earlier repairs. The text guard matches public-name branches insrc/effects/broker.rs:1239-1245selecting required Native effect kinds. Source audit confirms RSS still selects the six tool executions, while Native public-name policy affects permission admission, reservation and publication; an additional terminal-name gate exists before native process spawn. The recommended direction is captured RSS closed declarations -> sealed Native per-call policy -> actual primitive checks. The same-head source closure and full implementation specification are complete and parent-approved. The local candidate implements captured RSS declarations, sealed Native per-call policy and real primitive checks, including the necessary Native-only builtin revision coexistence/non-executable historical isolation and startup separation needed to keep retained Final receipts queryable. Historical activation/pins are not automatically replaced or granted current catalog authority; original architecture checks remain unchanged. Published implementation07e8f22a6233788d82e96d84be6a833cf58c3cc4has independent Grok CLEAN review, with no blocking or advisory findings for this scope. The 17-file candidate includes the captured RSS catalog, sealed Native policies/primitive checks and historical builtin initialization/replay compatibility; the original architecture guard is unchanged. Parent verification of raw source/Cargo JSON/actual test terminals and independent exit codes confirms scoped Debug322/0/0 and Release322/0/0, with architecture9/0 in both. A01-A11 named runtime mappings are verified; decisive assertion semantics and security review are accepted for this scope. Authentic cross-binary old Final replay has separate local Debug/Release probe evidence, alongside portable committed historical store/startup regressions. The failed3250 CI is retained as first-failure evidence; this revision has its own workflow. Cosmetic string rewrites and broad guard exclusions are not accepted. Later lifecycle targets were not reached, and the unchanged failed head has not been rerun.Previous-head CI run 39208310609 failed lifecycle: 39 passed / 1 failed (
deadline_terminates_child_process_without_residue, original PID assertion at1634:5). Actual CI lib passed453 / 0 / 6, managed38 / 0 and RSSarchitecture9 / 0, confirming the authority repair. The existing shipped failure trace reports202.866552ms remaining at admission, two provider calls, zero observed owned PID and zero Native before/after-spawn markers. Root remains UNKNOWN; recurrence at the historical assertion does not establish identical cause or waive regression investigation. Existing-evidence/source-only analysis runs without a new timing sample or deadline/assertion changes. T11 implementation on branchfeat/managed-checkpoint-restorehas returned an incomplete, uncommitted checkpoint: 17 changed files are preserved, not a qualified candidate. A genuine configured RSS write/Native terminal read reached the checkpoint RED; v7 migration then failed because the pinned official SQLite SDK rejects a legal single CREATE TRIGGER at its internal semicolon (execute and transaction both actual inner/wrapper RC101). Independent frozen-source review completed: bounded final equality is not equivalent to the required monotonic history revisions and does not enforce immutable checkpoint rows or raw ref-deletion guards; the pinned SDK has no supported trigger path. The user explicitly authorized a narrow SDK single-statement/parser-and-trigger-authorization correction plus the Agent pin update. The user then requested all current task slot targets/tmp/shared be cleared and baselines rebuilt first: Core and Agent cleanup is read-back verified, all 17 T11 WIP source files and necessary evidence are preserved, and exact d938/07e8 focused Debug/Release baselines have completed with zero failures: Core SQLite named18/0 plus lifecycle12/0 in each profile; Agent architecture9/0 plus managed38/0 in each profile. Authorized SDK implementation produced local-only candidateb5066dd92fcd7c07df57e3ec2c29dbcf8c19c390(three files, branchfix/sqlite-single-statement-triggers). Muse Spark completed the full frozen-source review without a concrete functional/security code blocker; three advisories remain recorded. Grok4.7 completed committed-source qualification: 13 groups,207 unique actual passes with per-run before/after byte equality and independent inner/wrapperRC0 (old207 not added). Unsuppressed strict Clippy fails identically on d938 and b506; all20 observed diagnostics are inherited, candidate-only0. Parent retains that whole-project strict-lint failure as OPEN and does not count waivers or warning-modeRC0 as strict PASS; it does not expand this narrow SDK fix into unrelated compiler/VM lint cleanup. Scoped SDK dependency intake is accepted with advisories. Exact b506 is now published only onrustscript-lang/rustscript:fix/sqlite-single-statement-triggers, remote-ref and ls-remote readback verified. Grok4.7 produced local Agent intake candidate2461971324d312fc5824758b718c9f3afb7993a0onintegrate/managed-sdk-intake: exact pin/lock changes only for the three SDK Git packages plus a permanent six-case AgentRunner SQLite contract. Parent verified204 actual runtime passes across14committed-source configurations, including normal managedv6 write/foregroundread/reopen; this is not v7/R15. Raw Agent strict Clippy fails at unchanged journal.rs:368: the map_err logging closure becomes identity when workspace-io-fault is off. Local7be6454d41c72003297fe15a742c759e1ca5ad33fixes that journal cfg issue, preserves fault-only logging and error rejection, and has actual204 original runtime passes plus4 separately recorded document-gate passes; production library and SDK contract strict Clippy pass in default/all-feature configurations. The remaining default unit-harness lint is an unused test helper compiled under a wider cfg than its sole consumer. Parent applied only that helper cfg alignment (no production behavior/test/assertion removal). Grok is committing and checking the exact five-file final source with focused SDK/Native/document-gate/managed-reopen and actual unit-harness strict gates; the204 matrix is not being repeated for this test-only guard. Muse Spark became unavailable under Meta geographic-use policy (not HTTP429); no provider-routing bypass was attempted. The user explicitly selected GPT-6.1-Sol for this one-off full frozen-source intake review. Sol completed the whole five-file source review: no functional/security blocker, one low nonblocking advisory (document-gate positive proves real worker reachability rather than independent named-record persistence/readback). Parent retained the advisory without expanding scope. Grok final verification completed at exact299d60f1c25bdff71efceb03863842ffab021bf2: all five frozen files match the committed source; new-head focused runtime32/0 and actual default/all-feature unit-harness strict compilation0/0 are parent-verified. Historical7be204+document4 and production/SDK Clippy results remain labeled predecessor evidence, not rerun on299 or summed into its32. The complete source review is bound to299 and accepted with the one advisory. Exact299 is now published to this Draft PR; new-head CI39245232327 failed after8m47s atdependency_pin_tests(0passed/4failed): its independent reviewed-SDK constant still expects d938 while the authorized manifests/lock use b506. Fmt and warnings-denied Clippy passed, and outerlib454/0/6 passed; the expected nested fifo-error child is not the outer failure. This run did not reach the historical lifecycle case. First-failure logs are preserved; no unchanged CI rerun. Test-only correctiond37c8e0e0cf940793f1af83399d0dfabff71008cis now published and parent-reviewed line by line: independently fixed reviewed literalb506, canonicalHTTPS/exact40hex/three locksource/path/stale/abbreviation safeguards preserved, and explicit priord938 rejection added. Cargo.toml/lock and all production source remain byte-identical to299. Actual std-only rustc-direct Debug and optimized harnesses each passed4/0; authored prior/stale/abbreviated fixture runs each still fail as intended. No Cargo qualification is claimed for this direct driver. Parent verified exactbranch+PRheadreadback. The slot1 T11 implementation continues without shared writes; exact d37 is queued for its later integration. T11 full v7/checkpoint/newbranch-session-run restore implementation has resumed on isolated branchfeat/managed-checkpoint-restore-v7from the accepted299 foundation, reconciling the preserved17WIP files rather than overwriting journal/retention fixes; no v7/R15 or full-project shipping pass is claimed. An overwritten earlier partial receipt-test log is recorded as an evidence gap, not fabricated or counted as a pass. T11 WIP remains preserved; later restoration must reconcile this journal fix rather than blindly copying old source. No R15/full-project shipping qualification is claimed. Revision fences remain unchanged; no merge or release is authorized. The lifecycle source chain is now complete, but the concrete timing cause remains UNKNOWN and no runtime fix is established. Full-project CI remains RED and no shipping gate is waived.Retained failure and diagnostic evidence
Run 39143398262 at predecessor
2b39448failed the original 250ms native-PID assertion (lifecycle 39/1); its gateway target completed 68/68. Historical cause remains UNKNOWN. Current-head local lifecycle evidence is separately 40/40 in each of four feature/profile groups, without changing test source or budgets.Run 39134836379 at predecessor
5c0fbe7was cancelled after the test step remained unfinished beyond 62 minutes: outer lib 410 passed / 0 failed / 6 ignored; gateway 67 cases passed, withterminal_retry_gate_drop_retires_an_unentered_waiterunfinished and no target summary. No remote native stack was retained. The local watcher exit 124 is separate from remote cancellation. The current repair addresses a statically reachable lost-notification defect without claiming the exact historical blocked instruction.Pre-merge bb0 run 39127359466 failed the original 250ms lifecycle PID assertion (39/1). C5 run 39128370347 failed the native HTTPS notification receive with Disconnected, not a proved 3-second timeout (lib 404/1/6). Those historical causes remain UNKNOWN.
One separately approved Agent-only phase sample at C5 completed the original 40-case target, 39 passed / 1 failed, Cargo 101. It observed the deadline crossing the second durable provider completion/storage span, followed by ApprovalResolve=Deadline, before pinned/retained-child/lifecycle start. This identifies the new sample's phase, not its storage/VM/SQL internal cause and not the historical ordering. Temporary Agent source was fully restored and the official d938 Debug artifact rebound; no second sample or qualification credit.
Continuing plan
The managed synchronous T08/T10 implementation is included in this head. Checkpoint/branch restore, versioned plugin state, subsequent harness/API work and final end-to-end gates remain separate plan milestones. Existing checkpoint library tests do not by themselves establish a persistent managed restore path. This PR stays Draft and unmerged.
Latest CI / deployment-reference repair
836a415420e1e341ac1c57bd1c3e4b443610b5e4changes only three deployment-guide lines: approved full SDK revision in manifest/lock examples and its displayed abbreviation. Production source, dependencies and original tests are unchanged. The exact original std-only failing test/helpers were copied without assertion edits and executed on the actual worktree: RED0/1, then Debug1/0 and optimized1/0. This is rustc-direct extracted-case evidence, not a full15case Cargo-suite claim.T11 continuation checkpoint
Exact836 CI result
Closed deadline diagnostic / independent gate fix
Provider post-persist gate accepted and published
77653d574ebd4f0c451e443b5899fb5970f14cb6changes only src/durable_provider.rs: preserve the committed request and existing attempt/replay/recovery/crash behavior, but recheck the same cancellation/deadline immediately before transport preparation/inner.call. No SDK/store protocol/cache/budget changes.Exact776 first CI result