Repository navigation
refactor: remove obsolete website code and check unused exports - #1443
Open
fhammerschmidt wants to merge 7 commits into
Open
fhammerschmidt wants to merge 7 commits into
fhammerschmidt wants to merge 7 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Remove abandoned scripts, compiler installations, components, and data. Keep live MDX mappings and framework entry points, trim unused interfaces, and enforce the monorepo dead-value check in CI. Fixes rescript-lang#1409
fhammerschmidt
force-pushed
the
fix/1421-dead-code
branch
from
October 11, 2026 22:24
3cd3497 to
a2bdd1f
Compare
Remove 42 redundant implementation annotations and document keeping @LiVe in interfaces when available. Retain 44 annotations, each verified necessary by removing it individually and rerunning the analyzer.
Wait for the client router and a gallery state update before focusing the prerendered Get started link. This prevents a one-shot focus event from racing React hydration while preserving the no-prefetch, focus-prefetch, and blur-cleanup assertions.
Keep focused docs helpers in their workspace and retain contributor commands with an explicit purpose. Document manual tools and Yarn preparation behavior, and remove duplicate docs formatting and cleaning entries.
Remove the unused root homepage-performance alias also removed by rescript-lang#1419. CI still invokes the docs workspace command directly, and this avoids a conflict next to the dead-code check entry.
Include rescript-lang#1451 so its package-script audit can merge first without conflicts. Preserve the dead-code check and corrected repository-wide reanalyze commands.
Keep the package-script audit focused on the eight redundant entries. Explain retained manual commands in the PR description without duplicating package scripts and contributor documentation.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove obsolete compiler installations, CodeMirror 5 setup, scripts, shims, duplicate MDX components, the unused scroll-lock context and
stdlib-toc.json.Remove unused helpers, interface exports and model fields, plus four unused direct dependencies and their lockfile entries.
Add
yarn check:dead-codeand make unused ReScript values and exports fail CI across all workspaces. Keep record-field and argument diagnostics advisory. Put necessary@liveannotations on interfaces or standalone entrypoints, with each entrypoint annotated once.Make the homepage CSS prefetch test wait for hydration before focusing its link.
Merge last among the open #1421 PRs, including after #1451. Refresh the cleanup as the other changes land.
Part of #1421.
Fixes #1409