Repository navigation
ci: check ReScript formatting and committed output - #1448
fhammerschmidt wants to merge 7 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
guide | 117afd8 | Commit Preview URL Branch Preview URL |
Oct 14 2026, 08:39 PM |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa47e87128
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Lighthouse baselineCompared with target branch
Download the full Lighthouse reports and baseline Commit |
Remove compiler-generated tracked files identified by their committed header before rebuilding. Preserve handwritten JavaScript and detect output whose source was deleted or whose workspace was excluded from the build.
Keep focused docs helpers in their workspace and retain contributor commands with an explicit purpose. Document manual tools and Yarn preparation behavior, and remove duplicate docs formatting and cleaning entries.
Remove the unused root performance and preparation aliases and the redundant docs formatting entry also removed by #1419. Keep the workspace helpers and root formatter checks so the CI and script-audit PRs merge cleanly.
Include #1451 so its package-script audit can merge first without conflicts. Preserve the root ReScript formatting and generated-output checks and the docs formatting delegate.
Keep the package-script audit focused on the eight redundant entries. Explain retained manual commands in the PR description without duplicating package scripts and contributor documentation.
Keep route validation before the clean compiler rebuild and retain root-level formatting commands while merging master.
This branch was successfully deployed
1 participant
Extend
yarn ci:formatto check Oxfmt and ReScript formatting across all four workspaces. Run formatting from the repository root and have the docs workspace's formatting command delegate to it.Add
yarn ci:generatedto check tracked compiler output after a clean build. Identify generated files by their compiler header, remove them before rebuilding, and fail if the tracked output changes. This also catches output left behind by deleted or excluded sources.Regenerate the guide's stale
routes.jsxand document how to run and fix the new checks. The unused-value and export check is in #1443.Merge after #1451.
Part of #1421.
Fixes #1416 together with #1443.