Repository navigation
fix: enforce the guide lesson authoring contract - #1438
Open
fhammerschmidt wants to merge 2 commits into
Open
fhammerschmidt wants to merge 2 commits into
fhammerschmidt wants to merge 2 commits into
Conversation
Validate slug identifiers, 32-bit integer positions, and required exact output strings. Remove unused description and exercise title metadata and keep source paths only in build diagnostics. Run frontmatter and real lesson collection checks in Node as part of guide CI. Cover malformed fields, duplicate diagnostics, nested discovery, exact output, and path-free serialized lessons. Fixes rescript-lang#1404 Part of rescript-lang#1421.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Use shared Node and Vitest bindings in the content tests. Resolve conflicts with master while retaining lesson validation and browser history test commands.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate guide lesson IDs and exercise paths, and require positions to be signed 32-bit integers. Require a string
exercise.expectedOutputso missing or misspelled fields fail during the build. Preserve its exact whitespace and allow an empty string.Remove the unsupported manual checkpoint variant and unused
descriptionandexercise.titlefields. Keep source filenames for build diagnostics and duplicate checks, then leave them out of published lesson data.Run frontmatter and filesystem collection tests through the guide's CI command, covering invalid fields, duplicate IDs and positions, lesson ordering, and published data.
Part of #1421.
Fixes #1404