Repository navigation
fix: wait for runtime output before completing guide checkpoints - #1437
Merged
fhammerschmidt merged 4 commits intoOct 14, 2026
Merged
fhammerschmidt merged 4 commits into
fhammerschmidt merged 4 commits into
Conversation
Start every lesson with empty output instead of pre-completing the first checkpoint. Cover compiler loading and failure, iframe output, saved progress, and nonmatching output. Arrange navigation tests with explicit progress and isolate their storage. Fixes rescript-lang#1403 Part of rescript-lang#1421.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Match the API v8 configuration shape and setters used during compiler setup so checkpoint regressions reach compilation and iframe execution.
jderochervlk
approved these changes
Oct 13, 2026
Keep the shared MemoryRouter history fixture and checkpoint test isolation while incorporating the latest website changes.
Use the completedExerciseIds object expected by GuideLayout and check restored completion before navigating. The checkpoint fix no longer masks malformed saved progress with prefilled output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start each guide lesson with empty output so its checkpoint waits for matching runtime output. Remove the first lesson's prefilled success message, which completed and saved the checkpoint before the compiler loaded. Saved progress still enables navigation on later visits.
Cover compiler loading and failures, matching and nonmatching output, and saved progress in browser tests. Control compiler downloads at the CDN boundary while running the compiler manager and iframe normally. Use
MemoryRouterfor navigation tests and clear browser storage between them.Part of #1421.
Fixes #1403