Repository navigation
Drop JSON constants from bitwise-or structurally in JsonConstCleaner - #410
Merged
Merged
Conversation
The bitwise-or cleaning decided what to drop from the ORIGINAL_NODE attribute, which is not reliably present on re-decorated inner nodes, so a nested chain could collapse to a single 0. Flatten the chain and drop the target constants structurally instead; output is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonConstCleanerdecided which bitwise-or operand to drop from theORIGINAL_NODEattribute (isTransformed()). That attribute is not reliably present on re-decorated inner nodes, so a nested chain such asA | B | C | D | E | JSON_THROW_ON_ERRORcould collapse to a single0instead of dropping only the target constant.The chain is now flattened and the target constants are dropped structurally, independent of
ORIGINAL_NODE. Output is unchanged on the current engine - the full downgrade test suite passes with no fixture changes.This also makes the cleaning stable when a rule runs more than once over the same node, which the upcoming rector-src node-traverser simplification needs.