Repository navigation
Update DowngradeNullJson fixture to structural bitwise-or drop - #412
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DowngradePhp73JsonConstRectordrops a target JSON constant from a bitwise-or chain structurally (see #410 and the rule's ownin_bitwise.php.incunit fixture), soA | B | JSON_THROW_ON_ERRORbecomesA | Brather thanA | B | 0.This Issues fixture still expected the old
| 0placeholder. Updated the expected output to match the structural drop, keeping it consistent with the rule's unit fixtures.