Skip to content

FROMLIST: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 vqmmc-supply for UHS-I mode - #1341

Open
mchunara007 wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mchunara007:lyra_sdcard
Open

mchunara007 wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mchunara007:lyra_sdcard

Conversation

@mchunara007

Copy link
Copy Markdown

SD card is detected as SDHS instead of UHS-I because sdhc_2 was configured with vreg_s4a as vqmmc-supply, which cannot switch between 1.8V and 3.3V.

Switch vqmmc-supply to vreg_l2a and update its voltage range to 1800000-2960000 uV to enable proper UHS-I signaling.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

1 similar comment
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #1341 — validate-patch

PR: #1341

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1341 - PENDING: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 vqmmc-supply for UHS-I mode
Upstream commit: N/A
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: prefix; no upstream source to compare
Body preserves rationale ✅ Clear description of SD card UHS-I detection issue and fix
Fixes tag present/correct N/A No Fixes tag; acceptable for new board enablement
Authorship preserved ✅ Original author; Signed-off-by present
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi ✅ Changes vreg_l2a voltage range and sdhc_2 vqmmc-supply; technically sound

Issues

  • Integration presence: The commit shows only partial evidence in qcom-next/topics. The integration_presence_report.md indicates "partial - subject or partial tree evidence found, but full change was not verified" for both qcom-next and topics branches. This suggests the change may exist in a different form or is incomplete in the integration branches.

Verdict

This is a vendor work-in-progress patch (PENDING: prefix) that has not been posted upstream. The commit message is clear and the technical change is reasonable (switching SD card vqmmc-supply to enable voltage switching for UHS-I mode). However, the partial integration presence status requires investigation to ensure the change is not duplicated or conflicting with existing work in qcom-next/topics.

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: Partial — 1/1 commit(s) show partial integration evidence (subject or partial tree match found, but full change not verified in qcom-next or topics)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: c7896917e523946138ce654d4b6c1e33d5a8f4e5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] PENDING: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

@qlijarvis

Copy link
Copy Markdown

PR #1341 — checker-log-analyzer

PR: #1341
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/40319420515

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Pre-existing warnings only
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance ❌ PENDING: prefix not in allowed list
tag-check ✅ Valid prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1341 - PENDING: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 vqmmc-supply for UHS-I mode
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/40319420515
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Pre-existing warnings only
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance ❌ PENDING: prefix not in allowed list
tag-check ✅ Valid prefix present

❌ check-patch-compliance

Root cause: The commit uses PENDING: prefix, which is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: PENDING: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 vqmmc-supply for UHS-I mode
Commit summary does not start with a required prefix

Analysis:

This is a known limitation of the check-patch-compliance checker. The checker only accepts upstream-linkable prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (in maintainer tree)
  • UPSTREAM: (merged to mainline)
  • BACKPORT: (backported with modifications)

The PENDING: prefix is used for work-in-progress commits that haven't been posted upstream yet. While this prefix is valid for the repository's tagging policy (confirmed by tag-check passing), the check-patch-compliance checker does not recognize it.

Options:

  1. If this patch has been posted upstream: Change prefix to FROMLIST: and add a Link: trailer pointing to the lore.kernel.org URL

    git rebase -i <base_sha>   # mark commit as 'edit'
    git commit --amend -m "FROMLIST: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 vqmmc-supply for UHS-I mode"
    # Add Link: https://lore.kernel.org/... to commit body
    git rebase --continue
  2. If this patch is vendor-only or not yet posted: The checker will always fail for PENDING: commits. This is expected behavior for work-in-progress changes. The failure can be acknowledged as a known limitation.

Reproduce locally:

cd kernel-checkers
./check-patch-compliance.sh <base_sha> <head_sha>

✅ tag-check

Status: PASS

All commits have a valid subject prefix. The PENDING: prefix is acceptable for branches other than qcom-next/qcom-next-staging.

Verdict

1 known limitation to acknowledge:

The check-patch-compliance failure is a known checker limitation for PENDING: prefixed commits. The commit is properly tagged according to the repository's tagging policy (tag-check passes).

Recommended action:

  • If the patch has been posted upstream → change to FROMLIST: + add Link: trailer
  • If the patch is still work-in-progress → acknowledge the checker limitation and proceed with merge if the change is otherwise acceptable

The actual code change (switching SD card vqmmc-supply from vreg_s4a to vreg_l2a for UHS-I support) has no style, binding, or compilation issues.

@mchunara007 mchunara007 changed the title PENDING: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 vqmmc-supply for UHS-I mode FROMLIST: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 vqmmc-supply for UHS-I mode Oct 28, 2026
…or UHS-I mode

SD card is detected as SDHS instead of UHS-I because sdhc_2 was
configured with vreg_s4a as vqmmc-supply, which cannot switch
between 1.8V and 3.3V.

Switch vqmmc-supply to vreg_l2a and update its voltage range to
1800000-2960000 uV to enable proper UHS-I signaling.

Link: https://lore.kernel.org/all/20261028121840.3111281-1-monish.chunara@oss.qualcomm.com/

Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants