Skip to content

PENDING: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 vqmmc-supply for UHS-I mode - #2137

Open
ggiriprasad wants to merge 1 commit into
qualcomm-linux:tech/all/dt/qcs615from
ggiriprasad:tech/all/dt/qcs615
Open

ggiriprasad wants to merge 1 commit into
qualcomm-linux:tech/all/dt/qcs615from
ggiriprasad:tech/all/dt/qcs615

Conversation

@ggiriprasad

Copy link
Copy Markdown

SD card is detected as SDHS instead of UHS-I because sdhc_2 was configured with vreg_s4a as vqmmc-supply, which cannot switch between 1.8V and 3.3V.

Switch vqmmc-supply to vreg_l2a and update its voltage range to 1800000-2960000 uV to enable proper UHS-I signaling.

Reference: qualcomm-linux/kernel#1341

@qcomlnxci
qcomlnxci requested review from a team, aiquny, Dmitry Baryshkov (lumag) and Trilok Soni (trsoni) and removed request for a team October 28, 2026 09:20
@qcomlnxci
qcomlnxci requested a review from a team October 28, 2026 09:24
@qlijarvis

Copy link
Copy Markdown

PR #2137 — validate-patch

PR: #2137

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #2137 - PENDING: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 vqmmc-supply for UHS-I mode
Upstream commit: N/A (PENDING: prefix - not yet posted upstream)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: prefix - no upstream to compare
Body preserves rationale ✅ Clear explanation of SD card UHS-I detection issue
Fixes tag present/correct N/A No Fixes tag (new feature enablement, not a regression fix)
Authorship preserved ❌ From: Monish Chunara but Signed-off-by: Giri Prasad Goriparthi - mismatch
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi ✅ Changes are internally consistent: vreg_l2a voltage range updated and sdhc_2 vqmmc switched to vreg_l2a

Issues

  • Authorship mismatch: The commit author (From: Monish Chunara) does not match the Signed-off-by trailer (Giri Prasad Goriparthi). Either:
    • The author should be changed to Giri Prasad Goriparthi (if they wrote the patch), OR
    • Monish Chunara should add their own Signed-off-by line (if they are committing on behalf of Giri)

Verdict

Request authorship correction before merge. The technical change is sound, but the commit metadata needs to be fixed to properly attribute the work.

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Partial — 1/1 commit(s) only have partial integration evidence (subject or partial tree evidence found, but full change was not verified)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: c7896917e523946138ce654d4b6c1e33d5a8f4e5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] PENDING: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

@qlijarvis

Copy link
Copy Markdown

PR #2137 — checker-log-analyzer

PR: #2137
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/40663915230

Checker Result Summary
Checker Result Summary
checkpatch ❌ Missing Signed-off-by from nominal patch author
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ Invalid prefix PENDING:
tag-check ⚠️ PENDING: not suitable for merge (see below)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #2137 - PENDING: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 vqmmc-supply for UHS-I mode
Target branch: tech/all/dt/qcs615
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/40663915230

Checker Result Summary
checkpatch ❌ Missing Signed-off-by from nominal patch author
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ Invalid prefix PENDING:
tag-check ⚠️ PENDING: not suitable for merge (see below)

❌ checkpatch

Root cause: The commit author is Monish Chunara <monish.chunara@oss.qualcomm.com> but the only Signed-off-by: is from Giri Prasad Goriparthi <giri.goriparthi@oss.qualcomm.com>.

Failure details:

ERROR: Missing Signed-off-by: line by nominal patch author 'Monish Chunara <monish.chunara@oss.qualcomm.com>'
00a559c7994b28fc82325bf0d85d687e8bdd8f41 total: 1 errors, 0 warnings, 0 checks, 18 lines checked

Fix: Add the missing Signed-off-by: line for the patch author:

git commit --amend --signoff
# This will add: Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>

The commit should have both sign-offs (author first, then co-author):

Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
Signed-off-by: Giri Prasad Goriparthi <giri.goriparthi@oss.qualcomm.com>

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git HEAD~1..HEAD

❌ check-patch-compliance

Root cause: The commit subject starts with PENDING:, which is not in the allowed prefix list for check-patch-compliance.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 vqmmc-supply for UHS-I mode
Commit summary does not start with a required prefix

Why this fails: The check-patch-compliance checker only accepts upstream-linkable prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (in a maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

The PENDING: prefix indicates work-in-progress that has not been posted upstream. This is a known checker limitation — vendor-internal prefixes like PENDING: and QCLINUX: always fail this check.

Fix options:

  1. If this patch has been posted to a mailing list (lore.kernel.org):

    • Change prefix to FROMLIST:
    • Add Link: <lore-url> to the commit body
  2. If this is vendor-only work with no upstream equivalent:

    • Change prefix to QCLINUX:
    • Note: This will still fail check-patch-compliance (known limitation)
    • But it correctly indicates the patch origin
  3. If this is truly pending/work-in-progress:

    • Keep PENDING: prefix
    • Accept that check-patch-compliance will fail
    • This is expected behavior for WIP commits

Reproduce locally:

# The checker will always fail for PENDING: prefix
# Verify the prefix is appropriate for the patch's upstream status

⚠️ tag-check (manual check)

Status: The commit uses PENDING: prefix, which is a valid subject-line tag.

Context: Since the target branch is tech/all/dt/qcs615 (not qcom-next or qcom-next-staging), every commit must start with one of these prefixes:

  • FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Analysis: The commit subject is:

PENDING: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 vqmmc-supply for UHS-I mode

✅ The PENDING: prefix is present and valid for the tag-check requirement.

⚠️ However, PENDING: indicates this is work-in-progress. Consider:

  • Is this patch ready for merge into tech/all/dt/qcs615?
  • Should it be posted upstream first and changed to FROMLIST:?
  • Or is it vendor-specific and should use QCLINUX: instead?

Verdict

2 blockers must be fixed before merge:

  1. checkpatch ERROR — Add missing Signed-off-by: for the nominal patch author (Monish Chunara)
  2. check-patch-compliance FAIL — Decide on the correct prefix:
    • If posted upstream → FROMLIST: + add Link: tag
    • If vendor-only → QCLINUX: (will still fail checker, but correct semantically)
    • If truly WIP → keep PENDING: (accept checker failure)

Quick fix commands:

# Fix missing sign-off
git commit --amend --signoff

# If changing prefix (example: PENDING → QCLINUX)
git commit --amend
# Edit the subject line to replace PENDING: with QCLINUX:

Note: The check-patch-compliance failure for PENDING: prefix is a known checker limitation. If this is genuinely work-in-progress or vendor-only code, the checker will always fail — this is expected behavior. The critical blocker is the missing Signed-off-by: line.

…or UHS-I mode

SD card is detected as SDHS instead of UHS-I because sdhc_2 was
configured with vreg_s4a as vqmmc-supply, which cannot switch
between 1.8V and 3.3V.

Switch vqmmc-supply to vreg_l2a and update its voltage range to
1800000-2960000 uV to enable proper UHS-I signaling.

Link: https://lore.kernel.org/all/20261028121840.3111281-1-monish.chunara@oss.qualcomm.com/

Signed-off-by: Giri Prasad Goriparthi <giri.goriparthi@oss.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #2137 — validate-patch

PR: #2137

Verdict Issues Detailed Report
❌ 0 Full report

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/all/20261028121840.3111281-1-monish.chunara@oss.qualcomm.com/

  2. Lore link matches PR commits: Partial — diff content is faithful (line number differences are expected due to different tree base), but commit message is missing the original author's Signed-off-by, which is a critical authorship violation for FROMLIST commits

  3. Upstream patch status: ⏳ Decision Pending — Konrad Dybcio replied on 2026-10-28 requesting "Please fix the base series then", indicating the patch is blocked pending resolution of the base series (https://lore.kernel.org/all/20261027-talos-lyra-evk-v2-v3-2-658fd5a7ec99@oss.qualcomm.com/). No merge or NAK decision yet.

  4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #2137 - FROMLIST: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 vqmmc-supply for UHS-I mode
Upstream commit: https://lore.kernel.org/all/20261028121840.3111281-1-monish.chunara@oss.qualcomm.com/
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream ✅ Subject identical except for FROMLIST: prefix
Body preserves rationale ✅ Body text identical to lore patch
Fixes tag present/correct N/A No Fixes tag in upstream or PR
Authorship preserved ❌ CRITICAL: Original lore author Monish Chunara <monish.chunara@oss.qualcomm.com> missing from Signed-off-by: chain. PR From: is Giri Prasad Goriparthi but original author's SoB is absent
Backport note (if applicable) N/A Not a backport; FROMLIST: prefix correct

Diff

File Status Notes
arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi ✅ Code changes identical; line number differences (PR: @@ -97, @@ -354 vs lore: @@ -57, @@ -224) are due to different tree base - this is expected and acceptable

Issues

1. Missing original author's Signed-off-by (CRITICAL)

The lore patch was authored and signed by:

From: Monish Chunara <monish.chunara@oss.qualcomm.com>
Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>

The PR commit shows:

From: Giri Prasad Goriparthi <giri.goriparthi@oss.qualcomm.com>
Signed-off-by: Giri Prasad Goriparthi <giri.goriparthi@oss.qualcomm.com>

For FROMLIST: commits, the submitter (Giri) may legitimately differ from the lore author (Monish), but the original lore author's Signed-off-by: MUST be present in the commit message to preserve the chain of custody. This is missing.

Required fix:

git commit --amend
# Add before Giri's Signed-off-by:
Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
Signed-off-by: Giri Prasad Goriparthi <giri.goriparthi@oss.qualcomm.com>

2. Dependency note missing from PR commit message

The lore patch includes this important dependency note:

This patch depends on base series -
https://lore.kernel.org/all/20261027-talos-lyra-evk-v2-v3-2-658fd5a7ec99@oss.qualcomm.com/

This dependency information is absent from the PR commit message. While present in the Link: tag, the explicit dependency note should be preserved to help reviewers understand the prerequisite.

3. Context differences are acceptable

The PR diff shows different line numbers and slightly different context (e.g., RPMH_REGULATOR_MODE_LPM vs RPMH_REGULATOR_MODE_HPM in the context line at the regulator-initial-mode). This is expected when applying a patch to a different tree base and does not indicate a problem - the actual code changes are identical.

Verdict

Do not merge - The PR must be amended to include the original author's Signed-off-by: line. This is a mandatory requirement for FROMLIST: commits to preserve proper attribution and the chain of custody from the mailing list.

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/all/20261028121840.3111281-1-monish.chunara@oss.qualcomm.com/

  2. Lore link matches PR commits: Partial — diff content is faithful (line number differences are expected due to different tree base), but commit message is missing the original author's Signed-off-by, which is a critical authorship violation for FROMLIST commits

  3. Upstream patch status: ⏳ Decision Pending — Konrad Dybcio replied on 2026-10-28 requesting "Please fix the base series then", indicating the patch is blocked pending resolution of the base series (https://lore.kernel.org/all/20261027-talos-lyra-evk-v2-v3-2-658fd5a7ec99@oss.qualcomm.com/). No merge or NAK decision yet.

  4. PR present in qcom-next/topics: Partial — integration_presence_report.md shows "partial - subject or partial tree evidence found, but full change was not verified" for both qcom-next and topics branches

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: c7896917e523946138ce654d4b6c1e33d5a8f4e5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

@qlijarvis

Copy link
Copy Markdown

PR #2137 — checker-log-analyzer

PR: #2137
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/40745024225

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ All DTB validations passed
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ Author mismatch detected
tag-check ✅ Subject has valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #2137 - FROMLIST: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 vqmmc-supply for UHS-I mode
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/40745024225
Target branch: tech/all/dt/qcs615

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ All DTB validations passed
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ Author mismatch detected
tag-check ✅ Subject has valid FROMLIST: prefix

❌ check-patch-compliance

Root cause: The commit author in git differs from the original patch author on lore.kernel.org.

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: talos-lyra-evk: fix sdhc_2 vqmmc-supply for UHS-I mode
Author mismatch:
  Original author: Monish Chunara <monish.chunara@oss.qualcomm.com>
  Commit author : Giri Prasad Goriparthi <giri.goriparthi@oss.qualcomm.com>

Analysis:

The upstream patch on lore.kernel.org was authored by Monish Chunara, but the commit in this PR is authored by Giri Prasad Goriparthi. The check-patch-compliance checker enforces that backported/cherry-picked patches preserve the original author attribution.

Fix:

Amend the commit to restore the original author:

git commit --amend --author="Monish Chunara <monish.chunara@oss.qualcomm.com>"

If Giri Prasad Goriparthi contributed to the backport (e.g., resolving conflicts, adapting the patch), add a Signed-off-by: trailer to acknowledge the contribution while preserving the original authorship:

Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
Signed-off-by: Giri Prasad Goriparthi <giri.goriparthi@oss.qualcomm.com>

Reproduce locally:

# Fetch the upstream patch
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20261028121840.3111281-1-monish.chunara@oss.qualcomm.com/ -o /tmp/out

# Verify the original author
grep "^From:" /tmp/out/*.mbx

Verdict

One blocker to fix before merge: The author mismatch must be corrected to preserve proper attribution of the upstream patch. All other checkers passed or were correctly skipped.

@lumag Dmitry Baryshkov (lumag) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As requested by Konrad, squash into the base series. Also, there should be no empty lines between tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants