Repository navigation
fix: Google sign-in from the Android app was refused - #44
Merged
Merged
Conversation
Chrome Custom Tabs opened by the app mark the navigation as cross-site and send the app (android-app://app.splitpro) as the Referer, so /start showed the 'start signing in from the app' page. Accept our app's Referer, and log the headers of any refused start so the next mismatch is visible.
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android, tapping Continue with Google showed "To sign in to the SplitPro app, open the app and start signing in there." The
/startlogout-CSRF guard only allowedSec-Fetch-Site: none/same-origin, but Chrome Custom Tabs opened by an app sendandroid-app://<package>as the Referer and don't count as a direct navigation.Referer: android-app://app.splitpro(web pages can't set anandroid-app://Referer; only app-launched browser navigations carry it). Other packages are still refused.Sec-Fetch-Site, Referer and User-Agent when/startrefuses, to confirm on the next attempt.iOS (ASWebAuthenticationSession) already worked.