Repository navigation
fix: let Android's sign-in browser start Google sign-in - #45
Merged
Merged
Conversation
Android Custom Tabs arrive at /start as a plain cross-site navigation with no Referer, indistinguishable from a link on another site, so the logout-CSRF guard refused every Android Google sign-in. Drop the guard: the worst a link can do is sign the browser out of the web, and the account picker, PKCE and the fresh-session handoff check still protect the sign-in itself.
|
Caution Review failedThe pull request is closed.
Tip 🎯 Customize your risk assessments
✅ Automatic approvals, with your rules
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#44 didn't fix it. The new log line shows what Android's Custom Tab actually sends to
/start:Sec-Fetch-Site: cross-siteand no Referer, exactly like a link from another website, so there's nothing to tell them apart.isOwnNavigationguard and its 403 page./startalways signs the browser out and starts Google sign-in./startand sign them out of splitpro.app on the web (low impact). The sign-in itself stays protected by Google's account picker (prompt=select_account), PKCE, and the handoff only accepting a session created after/start.