Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/merge_input_reader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ namespace {
*/
class copy_first_with_id {
osmium::io::Writer* writer;
osmium::item_type type = osmium::item_type::undefined;
osmium::object_id_type id = 0;

public:
Expand All @@ -44,10 +45,11 @@ namespace {
}

void push_back(const osmium::OSMObject& obj) {
if (obj.id() != id) {
if (obj.id() != id || obj.type() != type) {
if (obj.visible()) {
(*writer)(obj);
}
type = obj.type();
id = obj.id();
}
}
Expand Down
26 changes: 26 additions & 0 deletions test/test_merge_input_reader.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,29 @@ def test_multibuffer_simplify(adder, tmp_path):
mir.apply(h, simplify=True)

assert h.data == ['N1/1', 'N2/1', 'W3/2']


def test_apply_to_reader_same_id_different_type(tmp_path):
mir = osmium.MergeInputReader()
mir.add_buffer(b"r1 v2 Mw1@", format='opl')

infile = tmp_path / 'input.opl'
infile.write_text(dedent("""\
n1 v1 x1 y1
w1 v1 Nn1
r1 v1 Mw1@
"""))
outfile = tmp_path / 'output.opl'

reader = osmium.io.Reader(str(infile))
writer = osmium.io.Writer(str(outfile))
try:
mir.apply_to_reader(reader, writer)
finally:
reader.close()
writer.close()

h = ListHandler()
osmium.apply(str(outfile), h)

assert h.data == ['N1/1', 'W1/1', 'R1/2']