Repository navigation
Conversation
OSM IDs are only unique per object type, so a changed relation with the same ID as a way or node in the input was dropped by apply_to_reader(). Fixes osmcode#318.
Member
|
We don't take AI mass PRs. |
Contributor
|
Same fix as osmcode/osmium-tool@f8ba3b3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MergeInputReader.apply_to_reader()only compared object IDs when picking the newest version of each object, so an object whose ID matched the previous object of a different type was dropped. In the example from #318,relation/1from the change file disappeared becauseway/1came right before it.The check now looks at both type and ID, the same way the
simplifybranch ofapply()already does and the way osmium-tool'sapply-changeswas fixed for the same bug.Added a regression test with a node, way and relation that all have ID 1. It fails on master (the relation is missing from the output) and passes with the change. Full test suite passes locally.
Fixes #318.