Repository navigation
Link projects not in the report and keep Left behind rows together on narrow screens - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish on the Left behind block from #56 and #58.
Projects outside the report link to GitLab. A
not in this reportproject used to be plain text.reachOfnow keeps theproject_urlfrom the Jira link that names the project, and the name links to it in three places: Left behind lines, the dashed card under Services, and the release post (- [partners/mobile](https://…/partners/mobile): not in this report).Rows stay together when space is tight. I checked the block in light theme and at 375px width. Light theme looked fine. Two things broke up rows in the narrow side column and on phones:
.gap-summary).To Do) wrapped to the left edge of a new line. It now sits right-aligned, under the end of its row.There is no horizontal scroll at 375px.
candidateOf(service, tag)replaces four copies of the same candidate lookup:pickOf,pickedFor, report loading, and reading the address.Tests: the existing smoke tests now check the project links on the page and in the post.
just lint,just test-ci(146, 100%) andjust test-smoke(27) pass.