Repository navigation
Test that Left behind rows stay together on a phone and that the Russian post lists them - #60
Merged
Conversation
…ian post lists them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests only. Two things from #58 and #59 had no test.
Narrow layout. The new smoke test opens the demo at 375x812 with api 2.5.0 and web 1.9.0 picked, then measures the Left behind block:
I checked that it catches regressions: without the
.gap-summaryrule, two summaries fail, and without.gap-dep-head > .status { margin-left: auto; }, both badges fail.Russian release post. The existing Russian Left behind test now opens the release post tab and checks that the post has the
Не войдёт в релиз (3)section. Before, only the translation-key check covered that string.just lint,just test-ci(146, 100%) andjust test-smoke(28) pass.