Skip to content

Use Node 24's bundled node-gyp for Visual Studio 2026 - #997

Merged
Anthony Kim (anthonykim1) merged 4 commits into
mainfrom
anthonykim1/upgrade-node-gyp-windows-arm64
Oct 21, 2026
Merged

Anthony Kim (anthonykim1) merged 4 commits into
mainfrom
anthonykim1/upgrade-node-gyp-windows-arm64

Conversation

@anthonykim1

@anthonykim1 Anthony Kim (anthonykim1) commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Unblocks: #995

  • Move GitHub Actions and the native-prebuild pipeline to Node.js 24.
  • Drop node-pty's node-gyp development dependency and use the copy bundled with npm.
  • Require Node.js 24 and npm 11.6.3 or newer through strict devEngines, so source checkouts fail early without changing the requirements for node-pty consumers.
  • Update compileCommands to invoke the bundled node-gyp through npm_config_node_gyp.
  • Regenerate the lockfile without node-gyp's dependency tree and remove the temporary package-release-age workaround.
  • Keep the existing CI matrix so windows-11-arm continues to verify the native ARM64 build with Visual Studio 2026.

Validated locally on macOS arm64 with Node.js 24.18.0 and npm 11.16.0:

  • npm ci --ignore-scripts — passed; 122 packages, 0 vulnerabilities.
  • npm run build and npm run lint — passed.
  • npm run compileCommands — passed with npm-bundled node-gyp@12.3.0.
  • npm run install — built the native addon with npm-bundled node-gyp@12.3.0.
  • npm test — 24 passing.

Inspirations from:

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@anthonykim1
Anthony Kim (anthonykim1) marked this pull request as draft October 20, 2026 23:52
@anthonykim1
Anthony Kim (anthonykim1) marked this pull request as ready for review October 20, 2026 23:53

@deepak1556 Robo (deepak1556) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we drop the node-gyp dependency and rely on the bundled version from npm, our current use cases can be switched to it and avoids developer churn in managing this dependency. You can make engine requirements strict on the package manifest to support VS 2026

@anthonykim1
Anthony Kim (anthonykim1) marked this pull request as draft October 21, 2026 18:34
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@anthonykim1 Anthony Kim (anthonykim1) changed the title Upgrade node-gyp for Visual Studio 2026 Use Node 24's bundled node-gyp for Visual Studio 2026 Oct 21, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@anthonykim1
Anthony Kim (anthonykim1) marked this pull request as ready for review October 21, 2026 19:59
@anthonykim1
Anthony Kim (anthonykim1) merged commit 8a123ee into main Oct 21, 2026
19 checks passed
@anthonykim1
Anthony Kim (anthonykim1) deleted the anthonykim1/upgrade-node-gyp-windows-arm64 branch October 21, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants