Repository navigation
Use Node 24's bundled node-gyp for Visual Studio 2026 - #997
Merged
Anthony Kim (anthonykim1) merged 4 commits intoOct 21, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Anthony Kim (anthonykim1)
marked this pull request as draft
October 20, 2026 23:52
Anthony Kim (anthonykim1)
marked this pull request as ready for review
October 20, 2026 23:53
Robo (deepak1556)
left a comment
Contributor
There was a problem hiding this comment.
Can we drop the node-gyp dependency and rely on the bundled version from npm, our current use cases can be switched to it and avoids developer churn in managing this dependency. You can make engine requirements strict on the package manifest to support VS 2026
Anthony Kim (anthonykim1)
marked this pull request as draft
October 21, 2026 18:34
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Anthony Kim (anthonykim1)
marked this pull request as ready for review
October 21, 2026 19:59
Raymond Zhao (rzhao271)
approved these changes
Oct 21, 2026
Anthony Kim (anthonykim1)
deleted the
anthonykim1/upgrade-node-gyp-windows-arm64
branch
October 21, 2026 20:07
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks: #995
node-gypdevelopment dependency and use the copy bundled with npm.devEngines, so source checkouts fail early without changing the requirements for node-pty consumers.compileCommandsto invoke the bundled node-gyp throughnpm_config_node_gyp.windows-11-armcontinues to verify the native ARM64 build with Visual Studio 2026.Validated locally on macOS arm64 with Node.js 24.18.0 and npm 11.16.0:
npm ci --ignore-scripts— passed; 122 packages, 0 vulnerabilities.npm run buildandnpm run lint— passed.npm run compileCommands— passed with npm-bundlednode-gyp@12.3.0.npm run install— built the native addon with npm-bundlednode-gyp@12.3.0.npm test— 24 passing.Inspirations from:
node-gyp's 18.x detection and v145 toolset mapping, first released innode-gyp12.1.0.node-gyppath to the copy that ships with npm and exports it asnpm_config_node_gyp.devEnginescontract, which applies beforeinstall,ci, andrunwithout imposing the same requirement on consumers.build-testmatrix.