Repository navigation
fix(retry): bound context-overflow negation matching - #8980
Conversation
Match negation asides at their semantic tokens, then fold surrounding whitespace in one forward pass. Preserve the bounded classification window and retry decisions. Add boundary, matcher-start and in-memory retry coverage.
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Maintainer integration into
This is maintainer integration, not an independent approval. |
…#9028) * docs(structure): keep error-detail.md within its line budget Join the sentence added by #8980 onto the preceding line of its paragraph; the rendered text is unchanged and the doc returns to 600 lines. * docs(es): translate the Claude Code MCP round-trip section Restore parity with #8949: the Spanish messaging reference carries the same claude mcp add example and external link as English, so the Spanish localization test passes again.
Summary
Match curated negation asides at a word or comma and consume their surrounding whitespace once. The shared context-overflow classifier keeps its existing lookbehind, clause boundaries and retry decisions. The English, Spanish and Korean Combo guides and the owning structure documents describe the change.
The regressions cover ordinary negation and punctuation, the start of each aside match, classification near the accepted diagnostic limit, and cancellation through an in-memory transient retry. The matcher-start assertion distinguishes the previous and updated behavior using two short ordinary sentences.
Verification
Validated on Windows x64 with Bun 1.4.4 at
5b2c7f3e955ddcb8781ca8213ca3dd5641d92c6c:bun scripts/test.ts --no-env-file --no-install --isolate --parallel=1 tests/lib/definite-overflow-verdict.test.ts tests/lib/upstream-retry.test.tspassed all 137 tests.bun scripts/test.ts --no-env-file --no-install --isolate --parallel=1 tests/routing/router-combo-failover-classification.test.ts tests/ci-workflows/docs-spanish-localization.test.ts tests/ci-workflows/file-size-ratchet.test.tspassed all 249 tests.bun run typecheckchecked 2,681 files.bun run structure:check,bun run privacy:scanandgit diff --checkpassed.Checklist
Summary by CodeRabbit